<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">We don’t actually need it to emit the debug info, but I’m using the type size to assert that perform a couple of sanity assertions for multi-piece debug values that helped catch a lot of bugs so far. We could also disable these assertion for types with zero size to allow for sizeless forward-declared types, but since the size field is there anyway, we might as well use it for something good.<div class=""><div class=""><br class=""></div><div class="">-- adrian</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Mar 1, 2015, at 3:24 PM, David Blaikie <<a href="mailto:dblaikie@gmail.com" class="">dblaikie@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><p dir="ltr" class="">Hey Adrian - what's the reason we need the type's size for optimized debug info output?</p>
<div class="gmail_quote">On Mar 1, 2015 2:11 PM, "Peter Collingbourne" <<a href="mailto:peter@pcc.me.uk" class="">peter@pcc.me.uk</a>> wrote:<br type="attribution" class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: pcc<br class="">
Date: Sun Mar 1 16:07:04 2015<br class="">
New Revision: 230914<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=230914&view=rev" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=230914&view=rev</a><br class="">
Log:<br class="">
DebugInfo: Give externally defined types a size and alignment where<br class="">
possible. Fixes PR22736.<br class="">
<br class="">
Modified:<br class="">
cfe/trunk/lib/CodeGen/CGDebugInfo.cpp<br class="">
cfe/trunk/test/CodeGenCXX/debug-info-template-explicit-specialization.cpp<br class="">
<br class="">
Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGDebugInfo.cpp?rev=230914&r1=230913&r2=230914&view=diff" target="_blank" class="">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGDebugInfo.cpp?rev=230914&r1=230913&r2=230914&view=diff</a><br class="">
==============================================================================<br class="">
--- cfe/trunk/lib/CodeGen/CGDebugInfo.cpp (original)<br class="">
+++ cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Sun Mar 1 16:07:04 2015<br class="">
@@ -647,11 +647,19 @@ CGDebugInfo::getOrCreateRecordFwdDecl(co<br class="">
unsigned Line = getLineNumber(RD->getLocation());<br class="">
StringRef RDName = getClassName(RD);<br class="">
<br class="">
+ uint64_t Size = 0;<br class="">
+ uint64_t Align = 0;<br class="">
+<br class="">
+ const RecordDecl *D = RD->getDefinition();<br class="">
+ if (D && D->isCompleteDefinition()) {<br class="">
+ Size = CGM.getContext().getTypeSize(Ty);<br class="">
+ Align = CGM.getContext().getTypeAlign(Ty);<br class="">
+ }<br class="">
<br class="">
// Create the type.<br class="">
SmallString<256> FullName = getUniqueTagTypeName(Ty, CGM, TheCU);<br class="">
llvm::DICompositeType RetTy = DBuilder.createReplaceableCompositeType(<br class="">
- getTagForRecord(RD), RDName, Ctx, DefUnit, Line, 0, 0, 0,<br class="">
+ getTagForRecord(RD), RDName, Ctx, DefUnit, Line, 0, Size, Align,<br class="">
llvm::DIDescriptor::FlagFwdDecl, FullName);<br class="">
ReplaceMap.emplace_back(<br class="">
std::piecewise_construct, std::make_tuple(Ty),<br class="">
<br class="">
Modified: cfe/trunk/test/CodeGenCXX/debug-info-template-explicit-specialization.cpp<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/debug-info-template-explicit-specialization.cpp?rev=230914&r1=230913&r2=230914&view=diff" target="_blank" class="">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/debug-info-template-explicit-specialization.cpp?rev=230914&r1=230913&r2=230914&view=diff</a><br class="">
==============================================================================<br class="">
--- cfe/trunk/test/CodeGenCXX/debug-info-template-explicit-specialization.cpp (original)<br class="">
+++ cfe/trunk/test/CodeGenCXX/debug-info-template-explicit-specialization.cpp Sun Mar 1 16:07:04 2015<br class="">
@@ -99,3 +99,11 @@ template <><br class="">
struct k<int>;<br class="">
template struct k<int>;<br class="">
// CHECK-NOT: ; [ DW_TAG_structure_type ] [k<int>]<br class="">
+<br class="">
+template <typename T><br class="">
+struct l {<br class="">
+ int x;<br class="">
+};<br class="">
+extern template class l<int>;<br class="">
+l<int> li;<br class="">
+// CHECK: [ DW_TAG_structure_type ] [l<int>] {{.*}}size {{[^0]}}<br class="">
<br class="">
<br class="">
_______________________________________________<br class="">
cfe-commits mailing list<br class="">
<a href="mailto:cfe-commits@cs.uiuc.edu" class="">cfe-commits@cs.uiuc.edu</a><br class="">
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank" class="">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br class="">
</blockquote></div>
</div></blockquote></div><br class=""></div></div></body></html>