<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Yes, it needs a test case. It is from a very large program involving templates and it will take time<div class="">for me to reduce it. In the meantime, it is a goodness to check for a pointer which will be </div><div class="">dereferenced in the callee right away.</div><div class=""><br class=""></div><div class="">- Fariborz</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Feb 26, 2015, at 10:35 AM, David Blaikie <<a href="mailto:dblaikie@gmail.com" class="">dblaikie@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><br class=""><div class="gmail_extra"><br class=""><div class="gmail_quote">On Thu, Feb 26, 2015 at 9:59 AM, Fariborz Jahanian <span dir="ltr" class=""><<a href="mailto:fjahanian@apple.com" target="_blank" class="">fjahanian@apple.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: fjahanian<br class="">
Date: Thu Feb 26 11:59:54 2015<br class="">
New Revision: 230649<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=230649&view=rev" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=230649&view=rev</a><br class="">
Log:<br class="">
Patch to prevent crash when default argument expression<br class="">
is null due to its previous bad declaration, etc.<br class=""></blockquote><div class=""><br class="">Test case?<br class=""> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<a href="rdar://19871240" class="">rdar://19871240</a><br class="">
<br class="">
Modified:<br class="">
cfe/trunk/lib/Sema/SemaChecking.cpp<br class="">
<br class="">
Modified: cfe/trunk/lib/Sema/SemaChecking.cpp<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaChecking.cpp?rev=230649&r1=230648&r2=230649&view=diff" target="_blank" class="">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaChecking.cpp?rev=230649&r1=230648&r2=230649&view=diff</a><br class="">
==============================================================================<br class="">
--- cfe/trunk/lib/Sema/SemaChecking.cpp (original)<br class="">
+++ cfe/trunk/lib/Sema/SemaChecking.cpp Thu Feb 26 11:59:54 2015<br class="">
@@ -6774,8 +6774,11 @@ void AnalyzeImplicitConversions(Sema &S,<br class="">
E = POE->getResultExpr();<br class="">
}<br class="">
<br class="">
- if (const OpaqueValueExpr *OVE = dyn_cast<OpaqueValueExpr>(E))<br class="">
- return AnalyzeImplicitConversions(S, OVE->getSourceExpr(), CC);<br class="">
+ if (const OpaqueValueExpr *OVE = dyn_cast<OpaqueValueExpr>(E)) {<br class="">
+ if (OVE->getSourceExpr())<br class="">
+ AnalyzeImplicitConversions(S, OVE->getSourceExpr(), CC);<br class="">
+ return;<br class="">
+ }<br class="">
<br class="">
// Skip past explicit casts.<br class="">
if (isa<ExplicitCastExpr>(E)) {<br class="">
<br class="">
<br class="">
_______________________________________________<br class="">
cfe-commits mailing list<br class="">
<a href="mailto:cfe-commits@cs.uiuc.edu" class="">cfe-commits@cs.uiuc.edu</a><br class="">
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank" class="">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br class="">
</blockquote></div><br class=""></div></div>
</div></blockquote></div><br class=""></div></body></html>