<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Feb 24, 2015 at 5:11 PM, Richard Smith <span dir="ltr"><<a href="mailto:richard-llvm@metafoo.co.uk" target="_blank">richard-llvm@metafoo.co.uk</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Author: rsmith<br>
Date: Tue Feb 24 19:11:29 2015<br>
New Revision: 230417<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=230417&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=230417&view=rev</a><br>
Log:<br>
Make RedeclarableResult's ownership-transferring constructor be a move<br>
constructor.<br>
<br>
Modified:<br>
    cfe/trunk/lib/Serialization/ASTReaderDecl.cpp<br>
<br>
Modified: cfe/trunk/lib/Serialization/ASTReaderDecl.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Serialization/ASTReaderDecl.cpp?rev=230417&r1=230416&r2=230417&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Serialization/ASTReaderDecl.cpp?rev=230417&r1=230416&r2=230417&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/Serialization/ASTReaderDecl.cpp (original)<br>
+++ cfe/trunk/lib/Serialization/ASTReaderDecl.cpp Tue Feb 24 19:11:29 2015<br>
@@ -127,16 +127,16 @@ namespace clang {<br>
       Decl *MergeWith;<br>
       mutable bool Owning;<br>
       Decl::Kind DeclKind;<br>
-<br>
+<br>
       void operator=(RedeclarableResult &) = delete;<br></blockquote><div><br>Isn't this (well, the normal copy ctor and copy assignment operator) already deleted by the presence of the move ctor?<br><br><br>(speaking of which... I/we/someone should really get around to making " definition of implicit copy constructor/assignment operator for '%s' is deprecated because it has a user-declared thing" a subflag of -Wdeprecated and turning it on for LLVM (& probably at Google too)... )<br> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
-<br>
+<br>
     public:<br>
       RedeclarableResult(ASTReader &Reader, GlobalDeclID FirstID,<br>
                          Decl *MergeWith, Decl::Kind DeclKind)<br>
         : Reader(Reader), FirstID(FirstID), MergeWith(MergeWith),<br>
           Owning(true), DeclKind(DeclKind) {}<br>
<br>
-      RedeclarableResult(const RedeclarableResult &Other)<br>
+      RedeclarableResult(RedeclarableResult &&Other)<br>
         : Reader(Other.Reader), FirstID(Other.FirstID),<br>
           MergeWith(Other.MergeWith), Owning(Other.Owning),<br>
           DeclKind(Other.DeclKind) {<br>
@@ -148,7 +148,7 @@ namespace clang {<br>
             Reader.PendingDeclChainsKnown.insert(FirstID).second)<br>
           Reader.PendingDeclChains.push_back(FirstID);<br>
       }<br>
-<br>
+<br>
       /// \brief Retrieve the first ID.<br>
       GlobalDeclID getFirstID() const { return FirstID; }<br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div></div>