<div dir="ltr">I think r230448 tests this (windows was broken without this preparatory change).</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Feb 24, 2015 at 7:21 PM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">test case?<div><div class="h5"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Feb 24, 2015 at 6:16 PM, Reid Kleckner <span dir="ltr"><<a href="mailto:reid@kleckner.net" target="_blank">reid@kleckner.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rnk<br>
Date: Tue Feb 24 20:16:02 2015<br>
New Revision: 230445<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=230445&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=230445&view=rev</a><br>
Log:<br>
Add missing MD canonicalization to MS vtable builder<br>
<br>
Modified:<br>
    cfe/trunk/lib/AST/VTableBuilder.cpp<br>
<br>
Modified: cfe/trunk/lib/AST/VTableBuilder.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/VTableBuilder.cpp?rev=230445&r1=230444&r2=230445&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/VTableBuilder.cpp?rev=230445&r1=230444&r2=230445&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/AST/VTableBuilder.cpp (original)<br>
+++ cfe/trunk/lib/AST/VTableBuilder.cpp Tue Feb 24 20:16:02 2015<br>
@@ -2930,6 +2930,7 @@ static void GroupNewVirtualOverloads(<br>
   typedef llvm::DenseMap<DeclarationName, unsigned> VisitedGroupIndicesTy;<br>
   VisitedGroupIndicesTy VisitedGroupIndices;<br>
   for (const auto *MD : RD->methods()) {<br>
+    MD = MD->getCanonicalDecl();<br>
     VisitedGroupIndicesTy::iterator J;<br>
     bool Inserted;<br>
     std::tie(J, Inserted) = VisitedGroupIndices.insert(<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div></div></div></div>
<br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br></div>