<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Feb 24, 2015, at 5:12 PM, David Blaikie <<a href="mailto:dblaikie@gmail.com" class="">dblaikie@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><br class="Apple-interchange-newline"><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><div class="gmail_quote" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">On Tue, Feb 24, 2015 at 4:59 PM, Saleem Abdulrasool<span class="Apple-converted-space"> </span><span dir="ltr" class=""><<a href="mailto:abdulras@fb.com" target="_blank" class="">abdulras@fb.com</a>></span><span class="Apple-converted-space"> </span>wrote:<br class=""><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;"><span class="">REPOSITORY<br class=""> <span class="Apple-converted-space"> </span>rL LLVM<br class=""><br class="">================<br class="">Comment at: lib/CodeGen/CGDebugInfo.cpp:2379-2382<br class="">@@ -2378,4 +2378,6 @@<br class=""></span><span class=""> // we have support for emitting declarations of (non-member) global variables.<br class="">- VDContext = getContextDescriptor(<br class="">- dyn_cast<Decl>(VD->isStaticDataMember() ? VD->getLexicalDeclContext()<br class="">- : VD->getDeclContext()));<br class="">+ const DeclContext *DC = VD->isStaticDataMember() ? VD->getLexicalDeclContext()<br class="">+ : VD->getDeclContext();<br class="">+ while (DC->isRecord())<br class="">+ DC = DC->getParent();<br class="">+ VDContext = getContextDescriptor(dyn_cast<Decl>(DC));<br class=""></span>----------------<br class=""><span class="">friss wrote:<br class="">> The message makes it look like this change addresses a very particular case related to dllexport, yet the logic makes no mention of it. Care to elaborate why this doesn't change anything is other cases?<br class=""></span>The dllexport simply makes it easier to expose the issue as the member will be forcefully instantiated, and thus force the materialization of the debug info.<br class=""></blockquote><div class=""><br class="">You reckon this behavior could be tickled without dllexport? I think in any other case you'd need an explicit external definition - only in dllexport have I seen a definition manifested without one written outside the class.<br class=""></div></div></div></blockquote><div><br class=""></div><div>That’s what I was inferring from the fact that no other test needed to be updated. I think a comment pointing out that this happens only in very specific cases would be nice.</div><div><br class=""></div><div>Fred</div><div><br class=""></div><blockquote type="cite" class=""><div class=""><div class="gmail_quote" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div class=""> </div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;"><div class="HOEnZb"><div class="h5"><br class=""><a href="http://reviews.llvm.org/D7872" target="_blank" class="">http://reviews.llvm.org/D7872</a><br class=""><br class="">EMAIL PREFERENCES<br class=""> <span class="Apple-converted-space"> </span><a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank" class="">http://reviews.llvm.org/settings/panel/emailpreferences/</a></div></div></blockquote></div></div></blockquote></div><br class=""></body></html>