<div dir="ltr">Possibly. Lane splits make it a lot uglier than SSE2. I'm also somewhat concerned about the complete loss of size checking on the immediate. For instance 256 aliases to 0 in SSE2 case now. I hadn't thought about that when I reviewed your patch.</div><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Feb 15, 2015 at 4:56 PM, Filipe Cabecinhas <span dir="ltr"><<a href="mailto:filcab@gmail.com" target="_blank">filcab@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Craig,<div><br></div><div>Could this be done in the headers, like the 128-bit ones?</div><div>That way we could get rid of the builtins, no?</div><div><br></div><div>Thanks,</div><div class="gmail_extra"><br clear="all"><div><div> Filipe<br></div></div><div><div class="h5">
<br><div class="gmail_quote">On Sun, Feb 15, 2015 at 4:42 PM, Craig Topper <span dir="ltr"><<a href="mailto:craig.topper@gmail.com" target="_blank">craig.topper@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ctopper<br>
Date: Sun Feb 15 18:42:49 2015<br>
New Revision: 229348<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=229348&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=229348&view=rev</a><br>
Log:<br>
[X86] Teach clang to lower __builtin_ia32_psrldqi256 and __builtin_ia32_pslldqi256 to vector shuffles the backend recognizes. This is a step towards removing the corresponding intrinsics from the backend.<br>
<br>
Modified:<br>
cfe/trunk/lib/CodeGen/CGBuiltin.cpp<br>
cfe/trunk/test/CodeGen/avx2-builtins.c<br>
<br>
Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGBuiltin.cpp?rev=229348&r1=229347&r2=229348&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGBuiltin.cpp?rev=229348&r1=229347&r2=229348&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/CodeGen/CGBuiltin.cpp (original)<br>
+++ cfe/trunk/lib/CodeGen/CGBuiltin.cpp Sun Feb 15 18:42:49 2015<br>
@@ -6025,6 +6025,60 @@ Value *CodeGenFunction::EmitX86BuiltinEx<br>
// If palignr is shifting the pair of vectors more than 32 bytes, emit zero.<br>
return llvm::Constant::getNullValue(ConvertType(E->getType()));<br>
}<br>
+ case X86::BI__builtin_ia32_pslldqi256: {<br>
+ // Shift value is in bits so divide by 8.<br>
+ unsigned shiftVal = cast<llvm::ConstantInt>(Ops[1])->getZExtValue() >> 3;<br>
+<br>
+ // If pslldq is shifting the vector more than 15 bytes, emit zero.<br>
+ if (shiftVal >= 16)<br>
+ return llvm::Constant::getNullValue(ConvertType(E->getType()));<br>
+<br>
+ SmallVector<llvm::Constant*, 32> Indices;<br>
+ // 256-bit pslldq operates on 128-bit lanes so we need to handle that<br>
+ for (unsigned l = 0; l != 32; l += 16) {<br>
+ for (unsigned i = 0; i != 16; ++i) {<br>
+ unsigned Idx = 32 + i - shiftVal;<br>
+ if (Idx < 32) Idx -= 16; // end of lane, switch operand.<br>
+ Indices.push_back(llvm::ConstantInt::get(Int32Ty, Idx + l));<br>
+ }<br>
+ }<br>
+<br>
+ llvm::Type *VecTy = llvm::VectorType::get(Int8Ty, 32);<br>
+ Ops[0] = Builder.CreateBitCast(Ops[0], VecTy, "cast");<br>
+ Value *Zero = llvm::Constant::getNullValue(VecTy);<br>
+<br>
+ Value *SV = llvm::ConstantVector::get(Indices);<br>
+ SV = Builder.CreateShuffleVector(Zero, Ops[0], SV, "pslldq");<br>
+ llvm::Type *ResultType = ConvertType(E->getType());<br>
+ return Builder.CreateBitCast(SV, ResultType, "cast");<br>
+ }<br>
+ case X86::BI__builtin_ia32_psrldqi256: {<br>
+ // Shift value is in bits so divide by 8.<br>
+ unsigned shiftVal = cast<llvm::ConstantInt>(Ops[1])->getZExtValue() >> 3;<br>
+<br>
+ // If psrldq is shifting the vector more than 15 bytes, emit zero.<br>
+ if (shiftVal >= 16)<br>
+ return llvm::Constant::getNullValue(ConvertType(E->getType()));<br>
+<br>
+ SmallVector<llvm::Constant*, 32> Indices;<br>
+ // 256-bit psrldq operates on 128-bit lanes so we need to handle that<br>
+ for (unsigned l = 0; l != 32; l += 16) {<br>
+ for (unsigned i = 0; i != 16; ++i) {<br>
+ unsigned Idx = i + shiftVal;<br>
+ if (Idx >= 16) Idx += 16; // end of lane, switch operand.<br>
+ Indices.push_back(llvm::ConstantInt::get(Int32Ty, Idx + l));<br>
+ }<br>
+ }<br>
+<br>
+ llvm::Type *VecTy = llvm::VectorType::get(Int8Ty, 32);<br>
+ Ops[0] = Builder.CreateBitCast(Ops[0], VecTy, "cast");<br>
+ Value *Zero = llvm::Constant::getNullValue(VecTy);<br>
+<br>
+ Value *SV = llvm::ConstantVector::get(Indices);<br>
+ SV = Builder.CreateShuffleVector(Ops[0], Zero, SV, "psrldq");<br>
+ llvm::Type *ResultType = ConvertType(E->getType());<br>
+ return Builder.CreateBitCast(SV, ResultType, "cast");<br>
+ }<br>
case X86::BI__builtin_ia32_movntps:<br>
case X86::BI__builtin_ia32_movntps256:<br>
case X86::BI__builtin_ia32_movntpd:<br>
<br>
Modified: cfe/trunk/test/CodeGen/avx2-builtins.c<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/avx2-builtins.c?rev=229348&r1=229347&r2=229348&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/avx2-builtins.c?rev=229348&r1=229347&r2=229348&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/test/CodeGen/avx2-builtins.c (original)<br>
+++ cfe/trunk/test/CodeGen/avx2-builtins.c Sun Feb 15 18:42:49 2015<br>
@@ -462,7 +462,7 @@ __m256i test_mm256_sign_epi32(__m256i a,<br>
}<br>
<br>
__m256i test_mm256_slli_si256(__m256i a) {<br>
- // CHECK: @llvm.x86.avx2.psll.dq<br>
+ // CHECK: shufflevector <32 x i8> zeroinitializer, <32 x i8> %{{.*}}, <32 x i32> <i32 13, i32 14, i32 15, i32 32, i32 33, i32 34, i32 35, i32 36, i32 37, i32 38, i32 39, i32 40, i32 41, i32 42, i32 43, i32 44, i32 29, i32 30, i32 31, i32 48, i32 49, i32 50, i32 51, i32 52, i32 53, i32 54, i32 55, i32 56, i32 57, i32 58, i32 59, i32 60><br>
return _mm256_slli_si256(a, 3);<br>
}<br>
<br>
@@ -517,7 +517,7 @@ __m256i test_mm256_sra_epi32(__m256i a,<br>
}<br>
<br>
__m256i test_mm256_srli_si256(__m256i a) {<br>
- // CHECK: @llvm.x86.avx2.psrl.dq<br>
+ // CHECK: shufflevector <32 x i8> %{{.*}}, <32 x i8> zeroinitializer, <32 x i32> <i32 3, i32 4, i32 5, i32 6, i32 7, i32 8, i32 9, i32 10, i32 11, i32 12, i32 13, i32 14, i32 15, i32 32, i32 33, i32 34, i32 19, i32 20, i32 21, i32 22, i32 23, i32 24, i32 25, i32 26, i32 27, i32 28, i32 29, i32 30, i32 31, i32 48, i32 49, i32 50><br>
return _mm256_srli_si256(a, 3);<br>
}<br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div></div></div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">~Craig</div>
</div>