<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=utf-8"><meta name=Generator content="Microsoft Word 14 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:"Lucida Sans Typewriter";
panose-1:2 11 5 9 3 5 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-GB link=blue vlink=purple><div class=WordSection1><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>Hi Pete,<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>It seems you forgot to add a comma when you merged the REQUIRES lines, and now these tests never run,<br>even when backtraces are enabled.<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal style='text-autospace:none'><b><span style='font-size:8.0pt;font-family:"Lucida Sans Typewriter"'>index 8b61b75..5fca8d8 100644<o:p></o:p></span></b></p><p class=MsoNormal style='text-autospace:none'><b><span style='font-size:8.0pt;font-family:"Lucida Sans Typewriter"'>--- a/test/Analysis/crash-trace.c<o:p></o:p></span></b></p><p class=MsoNormal style='text-autospace:none'><b><span style='font-size:8.0pt;font-family:"Lucida Sans Typewriter"'>+++ b/test/Analysis/crash-trace.c<o:p></o:p></span></b></p><p class=MsoNormal style='text-autospace:none'><span style='font-size:8.0pt;font-family:"Lucida Sans Typewriter"'>@@ -2,7 +2,8 @@<o:p></o:p></span></p><p class=MsoNormal style='text-autospace:none'><span style='font-size:8.0pt;font-family:"Lucida Sans Typewriter"'> // REQUIRES: crash-recovery<o:p></o:p></span></p><p class=MsoNormal style='text-autospace:none'><span style='font-size:8.0pt;font-family:"Lucida Sans Typewriter"'><o:p> </o:p></span></p><p class=MsoNormal style='text-autospace:none'><span style='font-size:8.0pt;font-family:"Lucida Sans Typewriter"'> // FIXME: CHECKs might be incompatible to win32.<o:p></o:p></span></p><p class=MsoNormal style='text-autospace:none'><span style='font-size:8.0pt;font-family:"Lucida Sans Typewriter"'>-// REQUIRES: shell<o:p></o:p></span></p><p class=MsoNormal style='text-autospace:none'><span style='font-size:8.0pt;font-family:"Lucida Sans Typewriter"'>+// Stack traces also require back traces.<o:p></o:p></span></p><p class=MsoNormal style='text-autospace:none'><span style='font-size:8.0pt;font-family:"Lucida Sans Typewriter"'>+// REQUIRES: shell backtrace<o:p></o:p></span></p><p class=MsoNormal style='text-autospace:none'><span style='font-size:8.0pt;font-family:"Lucida Sans Typewriter"'><o:p> </o:p></span></p><p class=MsoNormal style='text-autospace:none'><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>I think this needs a comma between “shell” and “backtrace” as otherwise lit is parsing this as the “shell backtrace” feature.</span><span style='font-size:8.0pt;font-family:"Lucida Sans Typewriter"'><o:p></o:p></span></p><p class=MsoNormal style='text-autospace:none'><span style='font-size:8.0pt;font-family:"Lucida Sans Typewriter"'><o:p> </o:p></span></p><p class=MsoNormal style='text-autospace:none'><b><span style='font-size:8.0pt;font-family:"Lucida Sans Typewriter"'>diff --git a/test/Parser/crash-report.c b/test/Parser/crash-report.c<o:p></o:p></span></b></p><p class=MsoNormal style='text-autospace:none'><b><span style='font-size:8.0pt;font-family:"Lucida Sans Typewriter"'>index 92bc9ba..840a2a5 100644<o:p></o:p></span></b></p><p class=MsoNormal style='text-autospace:none'><b><span style='font-size:8.0pt;font-family:"Lucida Sans Typewriter"'>--- a/test/Parser/crash-report.c<o:p></o:p></span></b></p><p class=MsoNormal style='text-autospace:none'><b><span style='font-size:8.0pt;font-family:"Lucida Sans Typewriter"'>+++ b/test/Parser/crash-report.c<o:p></o:p></span></b></p><p class=MsoNormal style='text-autospace:none'><span style='font-size:8.0pt;font-family:"Lucida Sans Typewriter"'>@@ -2,7 +2,8 @@<o:p></o:p></span></p><p class=MsoNormal style='text-autospace:none'><span style='font-size:8.0pt;font-family:"Lucida Sans Typewriter"'> // REQUIRES: crash-recovery<o:p></o:p></span></p><p class=MsoNormal style='text-autospace:none'><span style='font-size:8.0pt;font-family:"Lucida Sans Typewriter"'><o:p> </o:p></span></p><p class=MsoNormal style='text-autospace:none'><span style='font-size:8.0pt;font-family:"Lucida Sans Typewriter"'> // FIXME: CHECKs might be incompatible to win32.<o:p></o:p></span></p><p class=MsoNormal style='text-autospace:none'><span style='font-size:8.0pt;font-family:"Lucida Sans Typewriter"'>-// REQUIRES: shell<o:p></o:p></span></p><p class=MsoNormal style='text-autospace:none'><span style='font-size:8.0pt;font-family:"Lucida Sans Typewriter"'>+// Stack traces also require back traces.<o:p></o:p></span></p><p class=MsoNormal style='text-autospace:none'><span style='font-size:8.0pt;font-family:"Lucida Sans Typewriter"'>+// REQUIRES: shell backtrace<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>Same here.<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>Thanks,<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>Kristof<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><div style='border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt'><div><div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm'><p class=MsoNormal><b><span lang=EN-US style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'>From:</span></b><span lang=EN-US style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'> cfe-commits-bounces@cs.uiuc.edu [mailto:cfe-commits-bounces@cs.uiuc.edu] <b>On Behalf Of </b>Pete Cooper<br><b>Sent:</b> 10 February 2015 19:57<br><b>To:</b> Chandler Carruth<br><b>Cc:</b> Owen Anderson; Clang Commits<br><b>Subject:</b> Re: [PATCH] Teach llvm-lit about ENABLE_BACKTRACES<o:p></o:p></span></p></div></div><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal><o:p> </o:p></p><div><blockquote style='margin-top:5.0pt;margin-bottom:5.0pt'><div><p class=MsoNormal>On Feb 10, 2015, at 11:50 AM, Chandler Carruth <<a href="mailto:chandlerc@google.com">chandlerc@google.com</a>> wrote:<o:p></o:p></p></div><p class=MsoNormal><o:p> </o:p></p><div><div><p class=MsoNormal>This seems like a generally good thing to do if we're testing backtraces.<o:p></o:p></p><div><p class=MsoNormal><o:p> </o:p></p></div><div><p class=MsoNormal>Do you want to merge the REQUIRES lines? I don't feel strongly either way.<o:p></o:p></p></div></div></div></blockquote><p class=MsoNormal>Didn’t know we could. Thats useful. I merged them and retested that it still works.<br><br><o:p></o:p></p><div><div><div><p class=MsoNormal><o:p> </o:p></p></div><div><p class=MsoNormal>Feel free to commit whenever.<o:p></o:p></p></div></div></div><p class=MsoNormal>Thanks. Its r228735<o:p></o:p></p></div><div><p class=MsoNormal><o:p> </o:p></p></div><div><p class=MsoNormal>Pete<br><br><o:p></o:p></p><div><div><p class=MsoNormal><o:p> </o:p></p><div><p class=MsoNormal>On Tue, Feb 10, 2015 at 11:13 AM, Pete Cooper <<a href="mailto:peter_cooper@apple.com" target="_blank">peter_cooper@apple.com</a>> wrote:<o:p></o:p></p><p class=MsoNormal style='margin-bottom:12.0pt'>Hi Chandler, Owen<br><br>In your patches to LLVM which changed ThreadLocal and PrettyStackTrace, we ended up requiring ENABLE_BACKTRACES for PrettyStackTrace.<br><br>Trouble is, clang has 2 tests which check for the pretty stack trace on crashes. This patch teaches lit about the ENABLE_BACKTRACES option, and updates those 2 tests to use that option. Without this patch, clang fails to pass llvm-lit without back traces.<br><br>Thanks,<br>Pete<o:p></o:p></p></div><p class=MsoNormal><o:p> </o:p></p></div></div></div><p class=MsoNormal><o:p> </o:p></p></div></div></body></html>