<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">cc Daniel. Do you remember the reason why you add SDKROOT to lit for clang?<div class=""><br class=""></div><div class="">Steven</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Feb 3, 2015, at 2:10 PM, Steven Wu <<a href="mailto:stevenwu@apple.com" class="">stevenwu@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi Reid<div class=""><br class=""></div><div class="">Thanks for the suggestion. I am aware of the setting in lit.cfg but I assume some of the environment variables I want to remove from the driver tests might be useful in some other cases. </div><div class="">For example, SDKROOT is setup by lit.cfg. Although I am not aware of any clang tests will fail on mac os if this environment is not set (maybe compiler_rt really need it), setting that environment to the wrong path will definitely fail many driver tests. I am just being cautious by removing them only from driver tests, but I can try remove them from all clang tests and see what will happen.</div><div class=""><br class=""></div><div class="">Steven</div><div class=""> <br class=""><div class=""><blockquote type="cite" class=""><div class="">On Feb 3, 2015, at 1:55 PM, Reid Kleckner <<a href="mailto:rnk@google.com" class="">rnk@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">We already have this mechanism in test/lit.cfg. Feel free to add some more variables.</div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Tue, Feb 3, 2015 at 1:17 PM, Steven Wu <span dir="ltr" class=""><<a href="mailto:stevenwu@apple.com" target="_blank" class="">stevenwu@apple.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Ping. This is intended to avoid driver tests gets broken by the unexpected environment variable. They can be accidentally set by user or bots and report false positive in driver tests.<br class="">
<br class="">
<br class="">
<a href="http://reviews.llvm.org/D7135" target="_blank" class="">http://reviews.llvm.org/D7135</a><br class="">
<br class="">
EMAIL PREFERENCES<br class="">
<a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank" class="">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br class="">
<br class="">
<br class="">
<br class="">
_______________________________________________<br class="">
cfe-commits mailing list<br class="">
<a href="mailto:cfe-commits@cs.uiuc.edu" class="">cfe-commits@cs.uiuc.edu</a><br class="">
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank" class="">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br class="">
</blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></div></div>_______________________________________________<br class="">cfe-commits mailing list<br class=""><a href="mailto:cfe-commits@cs.uiuc.edu" class="">cfe-commits@cs.uiuc.edu</a><br class="">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits<br class=""></div></blockquote></div><br class=""></div></body></html>