<div dir="ltr">Thank you! <div>This (and the other fix) indeed unblock me! </div><div><br></div><div>--kcc </div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jan 29, 2015 at 5:11 AM, Daniel Jasper <span dir="ltr"><<a href="mailto:djasper@google.com" target="_blank">djasper@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: djasper<br>
Date: Thu Jan 29 07:11:47 2015<br>
New Revision: 227433<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=227433&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=227433&view=rev</a><br>
Log:<br>
clang-format: FIXME that led to access of uninitialized memory.<br>
<br>
I have so far not succeeded in finding a nicely reduced test case or an<br>
observable difference which could help me create a test failure without<br>
msan.<br>
<br>
Committing without test to unblock kcc's further fuzzing progress.<br>
<br>
Modified:<br>
    cfe/trunk/lib/Format/Format.cpp<br>
<br>
Modified: cfe/trunk/lib/Format/Format.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Format/Format.cpp?rev=227433&r1=227432&r2=227433&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Format/Format.cpp?rev=227433&r1=227432&r2=227433&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/Format/Format.cpp (original)<br>
+++ cfe/trunk/lib/Format/Format.cpp Thu Jan 29 07:11:47 2015<br>
@@ -845,8 +845,8 @@ private:<br>
   FormatToken *getNextToken() {<br>
     if (GreaterStashed) {<br>
       // Create a synthesized second '>' token.<br>
-      // FIXME: Increment Column and set OriginalColumn.<br>
       Token Greater = FormatTok->Tok;<br>
+      unsigned OriginalColumn = FormatTok->OriginalColumn;<br>
       FormatTok = new (Allocator.Allocate()) FormatToken;<br>
       FormatTok->Tok = Greater;<br>
       SourceLocation GreaterLocation =<br>
@@ -855,6 +855,7 @@ private:<br>
           SourceRange(GreaterLocation, GreaterLocation);<br>
       FormatTok->TokenText = ">";<br>
       FormatTok->ColumnWidth = 1;<br>
+      FormatTok->OriginalColumn = OriginalColumn;<br>
       GreaterStashed = false;<br>
       return FormatTok;<br>
     }<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>