<div dir="ltr"><div><div><div>Yes, I'll do it as soon as I can.<br><br></div>[OFF-TOPIC]<br></div>Can you take a look at this, do you think review process is needed?<br> <a href="https://github.com/oblitum/clang/commit/75b8059907ac0bccdc9f8cd719bdb779b11d2113">https://github.com/oblitum/clang/commit/75b8059907ac0bccdc9f8cd719bdb779b11d2113</a>.<br><br></div>Regards<br><br><br><br></div><div class="gmail_extra"><br><div class="gmail_quote">2015-01-23 11:25 GMT-02:00 Manuel Klimek <span dir="ltr"><<a href="mailto:klimek@google.com" target="_blank">klimek@google.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><span class="">On Fri Jan 23 2015 at 2:21:52 PM Francisco Lopes da Silva <<a href="mailto:oblita@gmail.com" target="_blank">oblita@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: francisco.lopes<br>
Date: Fri Jan 23 07:17:51 2015<br>
New Revision: 226908<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=226908&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=226908&view=rev</a><br>
Log:<br>
Sema: code completion for variadic prototypes.<br>
<br>
Modified:<br>
cfe/trunk/lib/Sema/<u></u>SemaCodeComplete.cpp<br>
<br>
Modified: cfe/trunk/lib/Sema/<u></u>SemaCodeComplete.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaCodeComplete.cpp?rev=226908&r1=226907&r2=226908&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/cfe/trunk/lib/Sema/<u></u>SemaCodeComplete.cpp?rev=<u></u>226908&r1=226907&r2=226908&<u></u>view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- cfe/trunk/lib/Sema/<u></u>SemaCodeComplete.cpp (original)<br>
+++ cfe/trunk/lib/Sema/<u></u>SemaCodeComplete.cpp Fri Jan 23 07:17:51 2015<br>
@@ -3966,9 +3966,11 @@ void Sema::CodeCompleteCall(Scope *S, Ex<br>
<br>
if (auto FP = T->getAs<FunctionProtoType>()) {<br>
if (!TooManyArguments(FP-><u></u>getNumParams(), Args.size(),<br>
- /*PartialOverloading=*/true))<br>
+ /*PartialOverloading=*/true) ||<br>
+ FP->isVariadic())<br></blockquote><div><br></div></span><div>Can you add a test for this?</div><span class=""><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Results.push_back(<u></u>ResultCandidate(FP));<br>
} else if (auto FT = T->getAs<FunctionType>())<br>
+ // No prototype and declaration, it may be a K & R style function.<br>
Results.push_back(<u></u>ResultCandidate(FT));<br>
}<br>
}<br>
<br>
<br>
______________________________<u></u>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/cfe-commits</a><br>
</blockquote></span></div></div>
<br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br></div>