<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On 21 January 2015 at 12:50, Francisco Lopes <span dir="ltr"><<a href="mailto:francisco.mailing.lists@oblita.com" target="_blank">francisco.mailing.lists@oblita.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><div><div><div>Hi Nick,<br><br><br></div>I didn't get what you mean exactly. Do you want just the FIXME comment back?<br></div></div></div></div></div></blockquote><div><br></div><div>Yep!</div><div><br></div><div>"opt" is a program that is part of llvm's build and clang's tests shouldn't be using it. That's what the FIXME is saying, clang tests which run "opt" need to be fixed.</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><div><div></div></div>Locally at my machine I've all llvm/clang/etc sources under /opt/src/llvm. I had<br></div>to use lit for the first time and it was a headache to find why nothing worked.<br><br></div>This small fix made lit works without problems, with all the stuff under /opt/src/llvm.<br><br><div><div><div><div>Although, I've used it to run clang tests solely (under /opt/src/llvm/tools/clang/test).<br><br></div><div>Since it's having no issues with tests files under /opt anymore, I'm not getting why the<br></div><div>FIXME note is still needed and what the file list you have shown means.<br></div></div></div></div></div></blockquote><div><br></div><div>Okay, now I have concerns about the rest of the patch. In particular, there's no reason that the same change to "opt" shouldn't also apply to the other program names. If you check out your llvm source into "/home/$USER/clang-check/llvm" then the tests will fail again. The problem is that \b is the wrong character since it matches "/". Does replacing all the "\b"s with "\s"s work?<br></div><div><br></div><div>Nick</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="gmail_extra"><div class="gmail_quote">2015-01-21 18:33 GMT-02:00 Nick Lewycky <span dir="ltr"><<a href="mailto:nlewycky@google.com" target="_blank">nlewycky@google.com</a>></span>:<div><div><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><div>On 5 January 2015 at 11:59, Francisco Lopes da Silva <span dir="ltr"><<a href="mailto:oblita@gmail.com" target="_blank">oblita@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Author: francisco.lopes<br>
Date: Mon Jan 5 13:59:24 2015<br>
New Revision: 225196<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=225196&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=225196&view=rev</a><br>
Log:<br>
Fix lit for builds under /opt<br>
<br>
Modified:<br>
cfe/trunk/test/lit.cfg<br>
<br>
Modified: cfe/trunk/test/lit.cfg<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/lit.cfg?rev=225196&r1=225195&r2=225196&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/lit.cfg?rev=225196&r1=225195&r2=225196&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/test/lit.cfg (original)<br>
+++ cfe/trunk/test/lit.cfg Mon Jan 5 13:59:24 2015<br>
@@ -306,14 +306,14 @@ tool_dirs = os.path.pathsep.join((clang_<br>
# For example, don't match 'clang-check-' or '.clang-format'.<br>
NoPreHyphenDot = r"(?<!(-|\.))"<br>
NoPostHyphenDot = r"(?!(-|\.))"<br>
+NoPostBar = r"(?!(/|\\))"<br>
<br>
for pattern in [r"\bFileCheck\b",<br>
r"\bc-index-test\b",<br>
NoPreHyphenDot + r"\bclang-check\b" + NoPostHyphenDot,<br>
NoPreHyphenDot + r"\bclang-format\b" + NoPostHyphenDot,<br>
NoPreHyphenDot + r"\bclang-interpreter\b" + NoPostHyphenDot,<br>
- # FIXME: Some clang test uses opt?<br>
- NoPreHyphenDot + r"\bopt\b" + NoPostHyphenDot,<br>
+ NoPreHyphenDot + r"\bopt\b" + NoPostBar + NoPostHyphenDot,<br></blockquote><div><br></div></div></div><div>Hrm? Clang tests still aren't supposed to be using opt. Please put the fixme back?<br></div><div><br></div><div>The list appears to be:</div><div> - CodeGen/packed-structure.c</div><div> - CodeGenCXX/for-range.cpp</div><div> - CodeGen/mozilla-ms-inline-asm.c</div><div> - CodeGen/2005-09-24-AsmUserPrefix.c</div><div> - CodeGenCXX/for-range-temporaries.cpp</div><div> - CodeGen/2008-07-17-no-emit-on-error.c</div><div> - CodeGen/2005-06-15-ExpandGotoInternalProblem.c</div><span><font color="#888888"><div><br></div><div>Nick</div></font></span><span><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
# Handle these specially as they are strings searched<br>
# for during testing.<br>
r"\| \bcount\b",<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></span></div><br></div></div>
<br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div></div></div><br></div>
</blockquote></div></div></div>