<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Jan 9, 2015, at 9:06 AM, David Blaikie <<a href="mailto:dblaikie@gmail.com" class="">dblaikie@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><br class=""><div class="gmail_extra"><br class=""><div class="gmail_quote">On Wed, Jan 7, 2015 at 12:31 PM, Marshall Clow <span dir="ltr" class=""><<a href="mailto:mclow.lists@gmail.com" target="_blank" class="">mclow.lists@gmail.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: marshall<br class="">
Date: Wed Jan 7 14:31:06 2015<br class="">
New Revision: 225375<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=225375&view=rev" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=225375&view=rev</a><br class="">
Log:<br class="">
In C++03, a bunch of the arithmetic/logical/comparison functors (such as add/equal_to/logical_or) were defined as deriving from binary_funtion. That restriction was removed in C++11, but the tests still check for this. Change the test to look for the embedded types first_argument/second_argument/result_type. No change to the library, just more standards-compliant tests. Thanks to STL @ Microsoft for the suggestion.<br class=""></blockquote><div class=""><br class="">Are there any tests around to ensure the C++03 behavior remains in C++03? Or is that not worth worrying about/preserving/implementing?</div></div></div></div></div></blockquote><br class=""></div><div>The tests will continue to pass if the functors are derived from binary_function (which is how libc++ implements them).</div><div><br class=""></div><div>Other than that, no.</div><div><br class=""></div><div>binary_function is an empty struct with three nested typedefs:</div><div><br class=""></div><div><div>template <class Arg1, class Arg2, class Result></div><div>struct binary_function</div><div>{</div><div> typedef Arg1 first_argument_type;</div><div> typedef Arg2 second_argument_type;</div><div> typedef Result result_type;</div><div>};</div><div class=""><br class=""></div><div class="">The tests (now) check for the existence (and correctness) of first_argument_type, second_argument_type and result_type.</div><div class=""><br class=""></div><div class="">— Marshall</div><div class=""><br class=""></div></div></body></html>