<html><body>
<p><font size="2" face="sans-serif">Thanks! Committed in r225182.</font><br>
<br>
<font size="2" face="sans-serif">Regards,</font><br>
<font size="2" face="sans-serif">Samuel</font><br>
<br>
<tt><font size="2">Rafael Espíndola <rafael.espindola@gmail.com> wrote on 12/16/2014 04:43:54 PM:<br>
<br>
> From: Rafael Espíndola <rafael.espindola@gmail.com></font></tt><br>
<tt><font size="2">> To: Samuel F Antao/Watson/IBM@IBMUS</font></tt><br>
<tt><font size="2">> Cc: Chandler Carruth <chandlerc@gmail.com>, llvm cfe <cfe-commits@cs.uiuc.edu></font></tt><br>
<tt><font size="2">> Date: 12/16/2014 05:00 PM</font></tt><br>
<tt><font size="2">> Subject: Re: [PATCH] Fix clash of gcc toolchains in driver regression tests</font></tt><br>
<tt><font size="2">> <br>
> LGTM<br>
> <br>
> On 3 October 2014 at 20:02, Samuel F Antao <sfantao@us.ibm.com> wrote:<br>
> > Ping!<br>
> ><br>
> > Thanks,<br>
> > Samuel<br>
> ><br>
> > 2014-09-11 9:49 GMT-04:00 Rafael Espíndola <rafael.espindola@gmail.com>:<br>
> >><br>
> >> On 10 September 2014 19:02, Samuel F Antao <sfantao@us.ibm.com> wrote:<br>
> >> > Hi all,<br>
> >> ><br>
> >> > Some regression tests for the driver rely on the minimal/dummy system<br>
> >> > root<br>
> >> > that comes in the Inputs folder included in the clang driver tests’s<br>
> >> > folder.<br>
> >> > The path to the right toolchain is specified using the —sysroot switch.<br>
> >> > However, if clang was configured with a custom gcc toolchain (either by<br>
> >> > using GCC_INSTALL_PREFIX in cmake or the equivalent configure command),<br>
> >> > the<br>
> >> > path to the custom gcc toolchain path takes precedence to the one<br>
> >> > specified<br>
> >> > by sysroot. This causes several regression tests to fail as they will be<br>
> >> > using an unexpected path.<br>
> >> > This patch fixes this issue by adding --gcc-toolchain=“” to all tests<br>
> >> > that<br>
> >> > rely on that. The empty string causes the driver to pick the path from<br>
> >> > sysroot instead. There aren’t any changes in the driver’s code, only the<br>
> >> > tests are modified. The driver's regression tests for hexagon also have<br>
> >> > similar issues but these require modifications in the driver’s code.<br>
> >> > I’ll<br>
> >> > send these fixes in a separate patch.<br>
> >><br>
> >> I think this is OK, but Chandler should probably have the final say.<br>
> >><br>
> >> Cheers,<br>
> >> Rafael<br>
> >><br>
> >> _______________________________________________<br>
> >> cfe-commits mailing list<br>
> >> cfe-commits@cs.uiuc.edu<br>
> >> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
> ><br>
> ><br>
> <br>
</font></tt></body></html>