<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div><blockquote type="cite" class=""><div class="">On Jan 2, 2015, at 7:10 AM, Richard Smith <<a href="mailto:richard@metafoo.co.uk" class="">richard@metafoo.co.uk</a>> wrote:</div><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote">On Tue, Dec 16, 2014 at 12:01 AM, Alexey Bataev <span dir="ltr" class=""><<a href="mailto:a.bataev@hotmail.com" target="_blank" class="">a.bataev@hotmail.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Author: abataev<br class="">
Date: Tue Dec 16 02:01:48 2014<br class="">
New Revision: 224329<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=224329&view=rev" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=224329&view=rev</a><br class="">
Log:<br class="">
Renamed RefersToEnclosingLocal bitfield to RefersToCapturedVariable.<br class="">
Bitfield RefersToEnclosingLocal of Stmt::DeclRefExprBitfields renamed to RefersToCapturedVariable to reflect latest changes introduced in commit 224323. Also renamed method Expr::refersToEnclosingLocal() to Expr::refersToCapturedVariable() and comments for constant arguments.<br class="">
No functional changes.<br class=""></blockquote><div class=""><br class=""></div><div class="">This seems like a bad idea for me. It's incorrect: for a lambda, the flag means that the DeclRefExpr refers to an enclosing local, and does *not* imply that the variable is necessarily captured. This confusion has already led to a bug (fixed in <span style="font-size:13px" class="">r225060).</span></div></div></div></div></div></blockquote><div><br class=""></div>If that’s actually a useful property to track, I have no complaint about tracking the two things separately. I don’t think DRE is short of bits.</div><div><br class=""></div><div>John.</div></body></html>