<div dir="ltr">Ooh, ouch. Any idea if this is worth a warning? (not sure if there's any particular axis to generalize it on to catch a broader class of problems)</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Dec 25, 2014 at 10:06 PM, David Majnemer <span dir="ltr"><<a href="mailto:david.majnemer@gmail.com" target="_blank">david.majnemer@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: majnemer<br>
Date: Fri Dec 26 00:06:56 2014<br>
New Revision: 224844<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=224844&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=224844&view=rev</a><br>
Log:<br>
Sema: Qualify getPrintable's Expr argument<br>
<br>
getPrintable has an overload which takes a bool.  This means that const<br>
qualified Exprs would get forwarded to the bool overload instead of the<br>
Expr overload.<br>
<br>
Modified:<br>
    cfe/trunk/include/clang/Sema/Sema.h<br>
<br>
Modified: cfe/trunk/include/clang/Sema/Sema.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Sema/Sema.h?rev=224844&r1=224843&r2=224844&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Sema/Sema.h?rev=224844&r1=224843&r2=224844&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/include/clang/Sema/Sema.h (original)<br>
+++ cfe/trunk/include/clang/Sema/Sema.h Fri Dec 26 00:06:56 2014<br>
@@ -1251,7 +1251,7 @@ public:<br>
   static QualType getPrintable(QualType T) { return T; }<br>
   static SourceRange getPrintable(SourceRange R) { return R; }<br>
   static SourceRange getPrintable(SourceLocation L) { return L; }<br>
-  static SourceRange getPrintable(Expr *E) { return E->getSourceRange(); }<br>
+  static SourceRange getPrintable(const Expr *E) { return E->getSourceRange(); }<br>
   static SourceRange getPrintable(TypeLoc TL) { return TL.getSourceRange();}<br>
<br>
   template<typename T1><br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>