<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Dec 18, 2014 at 3:14 PM, Fariborz Jahanian <span dir="ltr"><<a href="mailto:fjahanian@apple.com" target="_blank">fjahanian@apple.com</a>></span> wrote:<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: fjahanian<br>
Date: Thu Dec 18 17:14:51 2014<br>
New Revision: 224549<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=224549&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=224549&view=rev</a><br>
Log:<br>
[c Sema]. Patch fixes pointer-bool-conversion warning on C code<br>
when source range is incorrect causing the warning to be<br>
issued when it should not because expression is in a macro.<br>
rdar://19256338<br>
<br>
Modified:<br>
    cfe/trunk/lib/Sema/SemaChecking.cpp<br>
    cfe/trunk/test/Sema/warn-tautological-compare.c<br>
<br>
Modified: cfe/trunk/lib/Sema/SemaChecking.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaChecking.cpp?rev=224549&r1=224548&r2=224549&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaChecking.cpp?rev=224549&r1=224548&r2=224549&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/Sema/SemaChecking.cpp (original)<br>
+++ cfe/trunk/lib/Sema/SemaChecking.cpp Thu Dec 18 17:14:51 2014<br>
@@ -6685,11 +6685,11 @@ void AnalyzeImplicitConversions(Sema &S,<br>
   if (BO && BO->isLogicalOp()) {<br>
     Expr *SubExpr = BO->getLHS()->IgnoreParenImpCasts();<br>
     if (!IsLogicalAndOperator || !isa<StringLiteral>(SubExpr))<br>
-      ::CheckBoolLikeConversion(S, SubExpr, SubExpr->getExprLoc());<br>
+      ::CheckBoolLikeConversion(S, SubExpr, BO->getExprLoc());<br>
<br>
     SubExpr = BO->getRHS()->IgnoreParenImpCasts();<br>
     if (!IsLogicalAndOperator || !isa<StringLiteral>(SubExpr))<br>
-      ::CheckBoolLikeConversion(S, SubExpr, SubExpr->getExprLoc());<br>
+      ::CheckBoolLikeConversion(S, SubExpr, BO->getExprLoc());<br>
   }<br>
<br>
   if (const UnaryOperator *U = dyn_cast<UnaryOperator>(E))<br>
<br>
Modified: cfe/trunk/test/Sema/warn-tautological-compare.c<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Sema/warn-tautological-compare.c?rev=224549&r1=224548&r2=224549&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Sema/warn-tautological-compare.c?rev=224549&r1=224548&r2=224549&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/test/Sema/warn-tautological-compare.c (original)<br>
+++ cfe/trunk/test/Sema/warn-tautological-compare.c Thu Dec 18 17:14:51 2014<br>
@@ -77,4 +77,18 @@ void test3() {<br>
        (!array && array[0])) {} // expected-warning {{address of array 'array' will always evaluate to 'true'}}<br>
  }<br>
<br>
-<br>
+// rdar://19256338<br>
+#define SAVE_READ(PTR, RESULT) if( (PTR) && *(PTR) ) *RESULT=*PTR;<br>
+<br>
+// Source<br>
+typedef unsigned char Boolean;<br>
+struct HTTPClientPrivate<br>
+{<br>
+   Boolean readSuspended;<br>
+};<br>
+typedef struct HTTPClientPrivate * HTTPClientRef;<br>
+static void _HTTPClientErrorHandler( HTTPClientRef me)<br>
+{<br>
+  Boolean result;<br>
+  SAVE_READ(&me->readSuspended, &result);<br>
+}<br></blockquote><div><br>Could this test case be a bit simpler to highlight the specific issue being tested/addressed here? (I assume the test case doesn't require a class/struct, or two macro parameters, etc, etc... )<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div></div></div>