<div dir="ltr">Good catch. I updated the change excluding private operators too.<br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Dec 15, 2014 at 3:58 PM, Aaron Ballman <span dir="ltr"><<a href="mailto:aaron@aaronballman.com" target="_blank" class="cremed">aaron@aaronballman.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On Mon, Dec 15, 2014 at 3:22 PM, Samuel Benzaquen <<a href="mailto:sbenza@google.com" class="cremed">sbenza@google.com</a>> wrote:<br>
> Hi alexfh,<br>
><br>
> Warn when the return type of assign operators is not Class&.<br>
><br>
> <a href="http://reviews.llvm.org/D6667" target="_blank" class="cremed">http://reviews.llvm.org/D6667</a><br>
><br>
> Files:<br>
>   clang-tidy/google/AssignOperatorSignatureCheck.cpp<br>
>   clang-tidy/google/AssignOperatorSignatureCheck.h<br>
>   clang-tidy/google/CMakeLists.txt<br>
>   clang-tidy/google/GoogleTidyModule.cpp<br>
>   test/clang-tidy/google-assign-operator.cpp<br>
><br>
> EMAIL PREFERENCES<br>
>   <a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank" class="cremed">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
<br>
</div></div>+struct Deleted {<br>
+  // We don't check the return value of deleted operators.<br>
+  void operator=(const Deleted&) = delete;<br>
+  void operator=(Deleted&&) = delete;<br>
+};<br>
<br>
What about private declarations without a definition? Eg)<br>
<br>
class noncopyable {<br>
  noncopyable(const noncopyable&);<br>
  void operator=(const noncopyable&);<br>
};<br>
<br>
~Aaron<br>
</blockquote></div><br></div></div>