<html><head><style>body{font-family:Helvetica,Arial;font-size:13px}</style></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">> there is a good chance we won’t be adding boxing of pointers. </div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;"><br></div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">Do you mean pointers to void (valueWithPointer) or all the pointers, like NSObject * (valueWithNonretainedObject)?</div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;"><br></div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">Anyway, should I get rid of that functionality before submitting updated patch or keep it and, probably, drop later?</div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;"><br></div> <div id="bloop_sign_1418332207474221056" class="bloop_sign"><div style="font-family:helvetica,arial;font-size:13px">-- <br>AlexDenisov</div><div style="font-family:helvetica,arial;font-size:13px">Software Engineer, <a href="https://github.com/AlexDenisov">https://github.com/AlexDenisov</a></div></div> <br><p style="color:#000;">On 10 Dec 2014 at 23:00:38, jahanian (<a href="mailto:fjahanian@apple.com">fjahanian@apple.com</a>) wrote:</p> <blockquote type="cite" class="clean_bq"><span><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div></div><div>
<title></title>
<br class="">
<div>
<blockquote type="cite" class="">
<div class="">On Dec 9, 2014, at 12:21 AM, AlexDenisov <<a href="mailto:1101.debian@gmail.com" class="">1101.debian@gmail.com</a>> wrote:</div>
<div class="">
<div id="bloop_customfont" style="font-family: Helvetica, Arial; font-size: 13px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; margin: 0px;" class=""><br class="">
<div id="bloop_customfont" style="margin: 0px;" class=""><br class=""></div>
<div id="bloop_customfont" style="margin: 0px;" class="">>>
Also, why can’t place this under the umbrella
objc_boxed_expressions?</div>
<div id="bloop_customfont" style="margin: 0px;" class=""><br class=""></div>
<div id="bloop_customfont" style="margin: 0px;" class="">Version
3.5, for example, supports objc_boxed_expression but not
NSValue+boxed_expressions, </div>
<div id="bloop_customfont" style="margin: 0px;" class="">which
might cause weird compilation fails. Or did I get it wrong?</div>
</div>
</div>
</blockquote>
No wrong :).</div>
<div><br class="">
<blockquote type="cite" class="">
<div class="">
<div id="bloop_customfont" style="font-family: Helvetica, Arial; font-size: 13px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; margin: 0px;" class="">
<div id="bloop_customfont" style="margin: 0px;" class=""><br class=""></div>
<div id="bloop_customfont" style="margin: 0px;" class="">+
// Otherwise, require a declaration of
NSValue.</div>
<div id="bloop_customfont" style="margin: 0px;" class="">+
S.Diag(Loc,
diag::err_undeclared_nsvalue);</div>
<div id="bloop_customfont" style="margin: 0px;" class="">+
return nullptr;</div>
<div id="bloop_customfont" style="margin: 0px;" class="">+
}</div>
<div id="bloop_customfont" style="margin: 0px;" class="">+
} else if (!S.NSValueDecl->hasDefinition()) {</div>
<div id="bloop_customfont" style="margin: 0px;" class="">+
S.Diag(Loc, diag::err_undeclared_nsvalue);</div>
<div id="bloop_customfont" style="margin: 0px;" class=""><br class=""></div>
<div id="bloop_customfont" style="margin: 0px;" class="">>>
Maybe we should have a clearer diagnostic here.</div>
<div id="bloop_customfont" style="margin: 0px;" class=""><br class=""></div>
<div id="bloop_customfont" style="margin: 0px;" class="">Makes
sense, I used NSNumber' implementation here. I'd appreciate any
suggestions or advice on </div>
<div id="bloop_customfont" style="margin: 0px;" class="">how to
improve diagnostic here (and, probably, for NSNumber)</div>
</div>
</div>
</blockquote>
<div><br class=""></div>
Probably should allude to NSValue (or NSNumber) having no
definition (only forward declared). </div>
<div>But, it is not something I strongly argue for.</div>
<div><br class=""></div>
<div>P.S. there is a good chance we won’t be adding boxing of
pointers. </div>
<div><br class=""></div>
<div>Thanks, Fairborz</div>
<div><br class=""></div>
<div><br class=""></div>
<br class="">
</div></div></span></blockquote></body></html>