<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi Paul, <div class=""><br class=""></div><div class="">This change is causing a problem with the perf data.<br class=""><div class=""><br class=""></div><div class="">The bots set SVN_REVISION during builds. LNT then uses the revision that the compiler reports to index the performance data. With this change, all performance data is being lost (well it is all ending up as 0). All performance data being collected since this change has been lost on all the bots.</div><div class=""><br class=""></div><div class=""><a href="http://llvm-lnt.herokuapp.com/db_default/v4/nts/recent_activity" class="">http://llvm-lnt.herokuapp.com/db_default/v4/nts/recent_activity</a></div><div class=""><br class=""></div><div class="">We are going to need to change every bot/build to use the new name. Was it your intention to modify the build’s interface? If so, could you revert while we coordinate the bot updates?</div><div class=""><br class=""></div><div class="">Maybe making this not a silent error would help. Something like error if SVN_REVISION is passed and CLANG_REVISION is not. Then at least we don’t have compilers with no version data encoded in them, when we expect them to.</div><div class=""><br class=""></div><div class="">Thanks!</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Dec 5, 2014, at 9:07 PM, Robinson, Paul <<a href="mailto:Paul_Robinson@playstation.sony.com" class="">Paul_Robinson@playstation.sony.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="WordSection1" style="page: WordSection1; font-family: Helvetica; font-size: 13px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><span style="font-size: 11pt; font-family: Calibri, sans-serif; color: rgb(31, 73, 125);" class="">r223578, thanks!<o:p class=""></o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><a name="_MailEndCompose" class=""><span style="font-size: 11pt; font-family: Calibri, sans-serif; color: rgb(31, 73, 125);" class=""> </span></a></div><div style="border-style: none none none solid; border-left-color: blue; border-left-width: 1.5pt; padding: 0in 0in 0in 4pt;" class=""><div class=""><div style="border-style: solid none none; border-top-color: rgb(181, 196, 223); border-top-width: 1pt; padding: 3pt 0in 0in;" class=""><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><b class=""><span style="font-size: 10pt; font-family: Tahoma, sans-serif;" class="">From:</span></b><span style="font-size: 10pt; font-family: Tahoma, sans-serif;" class=""><span class="Apple-converted-space"> </span><a href="mailto:metafoo@gmail.com" class="">metafoo@gmail.com</a> [<a href="mailto:metafoo@gmail.com" class="">mailto:metafoo@gmail.com</a>]<span class="Apple-converted-space"> </span><b class="">On Behalf Of<span class="Apple-converted-space"> </span></b>Richard Smith<br class=""><b class="">Sent:</b><span class="Apple-converted-space"> </span>Friday, December 05, 2014 5:15 PM<br class=""><b class="">To:</b><span class="Apple-converted-space"> </span>Jordan Rose<br class=""><b class="">Cc:</b><span class="Apple-converted-space"> </span>Robinson, Paul; <a href="mailto:cfe-commits@cs.uiuc.edu" class="">cfe-commits@cs.uiuc.edu</a><br class=""><b class="">Subject:</b><span class="Apple-converted-space"> </span>Re: [PATCH] Rename preprocessor symbols to be more descriptive. NFC<o:p class=""></o:p></span></div></div></div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><o:p class=""> </o:p></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">+1.<o:p class=""></o:p></div></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><o:p class=""> </o:p></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">On Fri, Dec 5, 2014 at 4:35 PM, Jordan Rose <<a href="mailto:jordan_rose@apple.com" target="_blank" style="color: purple; text-decoration: underline;" class="">jordan_rose@apple.com</a>> wrote:<o:p class=""></o:p></div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">+1 from me, and I like the name choice.<o:p class=""></o:p></div><div class=""><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><br class="">> On Dec 5, 2014, at 15:41, Robinson, Paul <<a href="mailto:Paul_Robinson@playstation.sony.com" style="color: purple; text-decoration: underline;" class="">Paul_Robinson@playstation.sony.com</a>> wrote:<br class="">><br class="">> This seemed a *little* too intricate to commit directly even if it is NFC.<br class="">> Also gives everyone a chance to disagree with the name choices. :-)<br class="">><br class="">> This is a followup to a GetSVN.cmake change; Sean Silva and Jordan Rose<br class="">> asked to have the name of the SVN_REVISION/SVN_REPOSITORY symbols changed.<br class="">> This requires changing both the Makefile and CMakeLists.txt so they both<br class="">> generate the same symbol name, and Version.cpp which is the only consumer.<br class="">><br class="">> The header generated by CMakeLists.txt/GetSVN.cmake used to look like this:<br class="">><br class="">> #define LLVM_REVISION "223538"<br class="">> #define LLVM_REPOSITORY "<a href="http://llvm.org/svn/llvm-project/llvm/trunk" target="_blank" style="color: purple; text-decoration: underline;" class="">http://llvm.org/svn/llvm-project/llvm/trunk</a>"<br class="">> #define SVN_REVISION "223538"<br class="">> #define SVN_REPOSITORY "<a href="http://llvm.org/svn/llvm-project/cfe/trunk" target="_blank" style="color: purple; text-decoration: underline;" class="">http://llvm.org/svn/llvm-project/cfe/trunk</a>"<br class="">><br class="">> and now looks like this:<br class="">><br class="">> #define LLVM_REVISION "223538"<br class="">> #define LLVM_REPOSITORY "<a href="http://llvm.org/svn/llvm-project/llvm/trunk" target="_blank" style="color: purple; text-decoration: underline;" class="">http://llvm.org/svn/llvm-project/llvm/trunk</a>"<br class="">> #define CLANG_REVISION "223538"<br class="">> #define CLANG_REPOSITORY "<a href="http://llvm.org/svn/llvm-project/cfe/trunk" target="_blank" style="color: purple; text-decoration: underline;" class="">http://llvm.org/svn/llvm-project/cfe/trunk</a>"<br class="">><br class="">> --paulr<o:p class=""></o:p></div></div></div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class="">> <svn_revision.diff><br class=""><br class=""><br class="">_______________________________________________<br class="">cfe-commits mailing list<br class=""><a href="mailto:cfe-commits@cs.uiuc.edu" style="color: purple; text-decoration: underline;" class="">cfe-commits@cs.uiuc.edu</a><br class=""><a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank" style="color: purple; text-decoration: underline;" class="">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><o:p class=""></o:p></div></div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;" class=""><o:p class=""> </o:p></div></div></div></div><span style="font-family: Helvetica; font-size: 13px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">_______________________________________________</span><br style="font-family: Helvetica; font-size: 13px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 13px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">cfe-commits mailing list</span><br style="font-family: Helvetica; font-size: 13px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 13px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class=""><a href="mailto:cfe-commits@cs.uiuc.edu" class="">cfe-commits@cs.uiuc.edu</a></span><br style="font-family: Helvetica; font-size: 13px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 13px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class=""><a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" class="">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a></span></div></blockquote></div><br class=""></div></div></body></html>