<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Helvetica;
panose-1:2 11 6 4 2 2 2 2 2 4;}
@font-face
{font-family:Helvetica;
panose-1:2 11 6 4 2 2 2 2 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{mso-style-priority:99;
mso-style-link:"Balloon Text Char";
margin:0in;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma","sans-serif";}
span.apple-converted-space
{mso-style-name:apple-converted-space;}
span.BalloonTextChar
{mso-style-name:"Balloon Text Char";
mso-style-priority:99;
mso-style-link:"Balloon Text";
font-family:"Tahoma","sans-serif";}
span.EmailStyle20
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">No, that was not my intent at all; it was just a "shouldn't this have a better name?" review comment. Which I originally resisted, then gave in…<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">I had no idea anything outside of clang/lib/Basic/Version.cpp depended on it.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">I am perfectly happy to revert r223578 and leave everything the way it was!<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Gimme a second…<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">--paulr<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><a name="_MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></a></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Chris Matthews [mailto:chris.matthews@apple.com]
<br>
<b>Sent:</b> Wednesday, December 10, 2014 3:37 PM<br>
<b>To:</b> Robinson, Paul<br>
<b>Cc:</b> Richard Smith; Jordan Rose; cfe-commits@cs.uiuc.edu<br>
<b>Subject:</b> Re: [PATCH] Rename preprocessor symbols to be more descriptive. NFC<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Hi Paul, <o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">This change is causing a problem with the perf data.<o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">The bots set SVN_REVISION during builds. LNT then uses the revision that the compiler reports to index the performance data. With this change, all performance data is being lost (well it is all ending up as 0). All performance data being
collected since this change has been lost on all the bots.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal"><a href="http://llvm-lnt.herokuapp.com/db_default/v4/nts/recent_activity">http://llvm-lnt.herokuapp.com/db_default/v4/nts/recent_activity</a><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">We are going to need to change every bot/build to use the new name. Was it your intention to modify the build’s interface? If so, could you revert while we coordinate the bot updates?<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Maybe making this not a silent error would help. Something like error if SVN_REVISION is passed and CLANG_REVISION is not. Then at least we don’t have compilers with no version data encoded in them, when we expect them to.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Thanks!<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<p class="MsoNormal">On Dec 5, 2014, at 9:07 PM, Robinson, Paul <<a href="mailto:Paul_Robinson@playstation.sony.com">Paul_Robinson@playstation.sony.com</a>> wrote:<o:p></o:p></p>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">r223578, thanks!</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"> </span><o:p></o:p></p>
</div>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<div>
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span class="apple-converted-space"><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> </span></span><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""><a href="mailto:metafoo@gmail.com">metafoo@gmail.com</a>
[<a href="mailto:metafoo@gmail.com">mailto:metafoo@gmail.com</a>]<span class="apple-converted-space"> </span><b>On Behalf Of<span class="apple-converted-space"> </span></b>Richard Smith<br>
<b>Sent:</b><span class="apple-converted-space"> </span>Friday, December 05, 2014 5:15 PM<br>
<b>To:</b><span class="apple-converted-space"> </span>Jordan Rose<br>
<b>Cc:</b><span class="apple-converted-space"> </span>Robinson, Paul; <a href="mailto:cfe-commits@cs.uiuc.edu">
cfe-commits@cs.uiuc.edu</a><br>
<b>Subject:</b><span class="apple-converted-space"> </span>Re: [PATCH] Rename preprocessor symbols to be more descriptive. NFC</span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
<div>
<div>
<p class="MsoNormal">+1.<o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
<div>
<div>
<p class="MsoNormal">On Fri, Dec 5, 2014 at 4:35 PM, Jordan Rose <<a href="mailto:jordan_rose@apple.com" target="_blank"><span style="color:purple">jordan_rose@apple.com</span></a>> wrote:<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">+1 from me, and I like the name choice.<o:p></o:p></p>
</div>
<div>
<div>
<div>
<p class="MsoNormal"><br>
> On Dec 5, 2014, at 15:41, Robinson, Paul <<a href="mailto:Paul_Robinson@playstation.sony.com"><span style="color:purple">Paul_Robinson@playstation.sony.com</span></a>> wrote:<br>
><br>
> This seemed a *little* too intricate to commit directly even if it is NFC.<br>
> Also gives everyone a chance to disagree with the name choices. :-)<br>
><br>
> This is a followup to a GetSVN.cmake change; Sean Silva and Jordan Rose<br>
> asked to have the name of the SVN_REVISION/SVN_REPOSITORY symbols changed.<br>
> This requires changing both the Makefile and CMakeLists.txt so they both<br>
> generate the same symbol name, and Version.cpp which is the only consumer.<br>
><br>
> The header generated by CMakeLists.txt/GetSVN.cmake used to look like this:<br>
><br>
> #define LLVM_REVISION "223538"<br>
> #define LLVM_REPOSITORY "<a href="http://llvm.org/svn/llvm-project/llvm/trunk" target="_blank"><span style="color:purple">http://llvm.org/svn/llvm-project/llvm/trunk</span></a>"<br>
> #define SVN_REVISION "223538"<br>
> #define SVN_REPOSITORY "<a href="http://llvm.org/svn/llvm-project/cfe/trunk" target="_blank"><span style="color:purple">http://llvm.org/svn/llvm-project/cfe/trunk</span></a>"<br>
><br>
> and now looks like this:<br>
><br>
> #define LLVM_REVISION "223538"<br>
> #define LLVM_REPOSITORY "<a href="http://llvm.org/svn/llvm-project/llvm/trunk" target="_blank"><span style="color:purple">http://llvm.org/svn/llvm-project/llvm/trunk</span></a>"<br>
> #define CLANG_REVISION "223538"<br>
> #define CLANG_REPOSITORY "<a href="http://llvm.org/svn/llvm-project/cfe/trunk" target="_blank"><span style="color:purple">http://llvm.org/svn/llvm-project/cfe/trunk</span></a>"<br>
><br>
> --paulr<o:p></o:p></p>
</div>
</div>
</div>
<div>
<p class="MsoNormal">> <svn_revision.diff><br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu"><span style="color:purple">cfe-commits@cs.uiuc.edu</span></a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank"><span style="color:purple">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</span></a><o:p></o:p></p>
</div>
</div>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
</div>
</div>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Helvetica","sans-serif"">_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a></span><o:p></o:p></p>
</div>
</blockquote>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
</div>
</div>
</body>
</html>