Should be fixed in r223650.<br><br><div class="gmail_quote">On Wed Nov 19 2014 at 1:23:42 PM Evgeniy Stepanov <<a href="mailto:eugenis@google.com">eugenis@google.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="gmail_quote">On Wed Nov 19 2014 at 3:54:46 AM Eric Fiselier <<a href="mailto:eric@efcs.ca" target="_blank">eric@efcs.ca</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">It seems you are missing interceptors for wcstof, wcstod, and wcstold as well.<div><br></div><div>Could this be responsible for PR21579 as well?</div><div><a href="http://llvm.org/bugs/show_bug.cgi?id=21579" target="_blank">http://llvm.org/bugs/show_bug.<u></u>cgi?id=21579</a></div></div></blockquote><div><br></div></div><div class="gmail_quote"><div>Unlikely.</div></div><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><br><div><br></div><div>/Eric</div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Nov 18, 2014 at 2:44 AM, Evgeniy Stepanov <span dir="ltr"><<a href="mailto:eugenis@google.com" target="_blank">eugenis@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">We are missing interceptors for: wcstol, wcstoul, wcstoll, wcstoull.<div><div><br><div class="gmail_quote">On Mon Nov 17 2014 at 11:02:13 PM Kostya Serebryany <<a href="mailto:kcc@google.com" target="_blank">kcc@google.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">if msan does not see what's goign on inside libc we need to teach it -- it already has a bunch of libc interceptors, but clearly not all. <div>Do you know what libc function is called here? </div><div>Or how to reproduce the reports you've been seeing? <br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Nov 14, 2014 at 2:23 PM, Eric Fiselier <span dir="ltr"><<a href="mailto:eric@efcs.ca" target="_blank">eric@efcs.ca</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ericwf<br>
Date: Fri Nov 14 16:23:57 2014<br>
New Revision: 222052<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=222052&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=222052&view=rev</a><br>
Log:<br>
Initialize pointer in string conversion helpers to prevent MSAN diagnostic.<br>
<br>
Since the initialization of the pointer happens across the libc library boundry<br>
MSAN will not know the pointer was initialized. This fixes MSAN failures in<br>
test/strings/string.<u></u>conversions.<br>
<br>
Modified:<br>
libcxx/trunk/src/string.cpp<br>
<br>
Modified: libcxx/trunk/src/string.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/src/string.cpp?rev=222052&r1=222051&r2=222052&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/libcxx/trunk/src/<u></u>string.cpp?rev=222052&r1=<u></u>222051&r2=222052&view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- libcxx/trunk/src/string.cpp (original)<br>
+++ libcxx/trunk/src/string.cpp Fri Nov 14 16:23:57 2014<br>
@@ -63,7 +63,7 @@ inline<br>
V<br>
as_integer_helper(const string& func, const S& str, size_t* idx, int base, F f)<br>
{<br>
- typename S::value_type* ptr;<br>
+ typename S::value_type* ptr = nullptr;<br>
const typename S::value_type* const p = str.c_str();<br>
typename remove_reference<decltype(<u></u>errno)>::type errno_save = errno;<br>
errno = 0;<br>
@@ -180,7 +180,7 @@ inline<br>
V<br>
as_float_helper(const string& func, const S& str, size_t* idx, F f )<br>
{<br>
- typename S::value_type* ptr;<br>
+ typename S::value_type* ptr = nullptr;<br>
const typename S::value_type* const p = str.c_str();<br>
typename remove_reference<decltype(<u></u>errno)>::type errno_save = errno;<br>
errno = 0;<br>
<br>
<br>
______________________________<u></u>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>
</blockquote></div>
</div></div></blockquote></div><br></div>
</blockquote></div></blockquote></div>