<br><br><div class="gmail_quote">On Fri Dec 05 2014 at 6:28:02 AM Jonathan Roelofs <<a href="mailto:jonathan@codesourcery.com">jonathan@codesourcery.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
<br>
On 12/4/14 5:22 PM, Eric Christopher wrote:<br>
> Author: echristo<br>
> Date: Thu Dec  4 18:22:48 2014<br>
> New Revision: 223422<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=223422&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=223422&view=rev</a><br>
> Log:<br>
> Use isOSBinFormatMachO() instead of comparing the object format<br>
> against an enum.<br>
><br>
...<br>
> Modified: cfe/trunk/lib/Driver/Tools.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Tools.cpp?rev=223422&r1=223421&r2=223422&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/cfe/trunk/lib/Driver/<u></u>Tools.cpp?rev=223422&r1=<u></u>223421&r2=223422&view=diff</a><br>
> ==============================<u></u>==============================<u></u>==================<br>
> --- cfe/trunk/lib/Driver/Tools.cpp (original)<br>
> +++ cfe/trunk/lib/Driver/Tools.cpp Thu Dec  4 18:22:48 2014<br>
> @@ -772,8 +772,7 @@ void Clang::AddARMTargetArgs(const ArgLi<br>
>       // The backend is hardwired to assume AAPCS for M-class processors, ensure<br>
>       // the frontend matches that.<br>
>       if (Triple.getEnvironment() == llvm::Triple::EABI ||<br>
> -        (Triple.getOS() == llvm::Triple::UnknownOS &&<br>
> -         Triple.getObjectFormat() == llvm::Triple::MachO) ||<br>
> +        Triple.getOS() == llvm::Triple::UnknownOS ||<br>
Eric, I think you forgot a 'Triple.isOSBinFormatMachO()' here.<br>
<br>
<br></blockquote><div><br></div><div>Nope, it's covered earlier before we get this far :)</div><div><br></div><div>-eric</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Cheers,<br>
<br>
Jon<br>
>           StringRef(CPUName).startswith(<u></u>"cortex-m")) {<br>
>         ABIName = "aapcs";<br>
>       } else {<br>
><br>
...<br>
> ______________________________<u></u>_________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/cfe-commits</a><br>
><br>
<br>
--<br>
Jon Roelofs<br>
<a href="mailto:jonathan@codesourcery.com" target="_blank">jonathan@codesourcery.com</a><br>
CodeSourcery / Mentor Embedded<br>
</blockquote></div>