<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">How about now? I’d like to clean up that FIXME and Xcode 4.6 has been out for a long time….<div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Nov 11, 2013, at 1:07 PM, Nico Weber <<a href="mailto:thakis@chromium.org" class="">thakis@chromium.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">On Mon, Nov 11, 2013 at 12:17 PM, Bob Wilson <span dir="ltr" class=""><<a href="mailto:bob.wilson@apple.com" target="_blank" class="">bob.wilson@apple.com</a>></span> wrote:<br class=""><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word" class="">Nico,<div class=""><br class=""></div><div class="">Have you upgraded your bots to Xcode 4.6 or Xcode 5.0 yet?</div>
</div></blockquote><div class=""><br class=""></div><div class="">No, not yet. But with the talk of LLVM moving to C++11 (which I suppose implies using libc++ on OS X), chances are it'll happen relatively soon.</div><div class=""> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word" class=""><div class=""><div class="h5"><div class=""><br class=""><div class=""><div class="">On Mar 12, 2013, at 12:54 PM, Bob Wilson <<a href="mailto:bob.wilson@apple.com" target="_blank" class="">bob.wilson@apple.com</a>> wrote:</div><br class=""><blockquote type="cite" class="">
<div style="word-wrap:break-word" class="">No, sorry, I just figured that you would have updated by now. Would you like me to put it back again?<div class=""><br class=""><div class=""><div class="">On Mar 12, 2013, at 12:49 PM, Nico Weber <<a href="mailto:thakis@chromium.org" target="_blank" class="">thakis@chromium.org</a>> wrote:</div>
<br class=""><blockquote type="cite" class=""><div dir="ltr" class="">Is there urgency to do this? Xcode 4.6 has been out for 2 months, and upgrading bots takes a while.</div><div class="gmail_extra"><br class=""><br class=""><div class="gmail_quote">On Tue, Mar 12, 2013 at 12:39 PM, Bob Wilson <span dir="ltr" class=""><<a href="mailto:bob.wilson@apple.com" target="_blank" class="">bob.wilson@apple.com</a>></span> wrote:<br class="">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: bwilson<br class="">
Date: Tue Mar 12 14:39:19 2013<br class="">
New Revision: 176887<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=176887&view=rev" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=176887&view=rev</a><br class="">
Log:<br class="">
Revert r166370 and r166540 now that Xcode 4.6 has been available for a while.<br class="">
<br class="">
Those changes were added as a temporary workaround for Xcode 4.5 passing the<br class="">
-Wno-arc-abi option. Xcode 4.6 does not pass that option so this should no<br class="">
longer be necessary.<br class="">
<br class="">
Modified:<br class="">
cfe/trunk/include/clang/Basic/DiagnosticGroups.td<br class="">
cfe/trunk/test/Driver/warning-options.cpp<br class="">
<br class="">
Modified: cfe/trunk/include/clang/Basic/DiagnosticGroups.td<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticGroups.td?rev=176887&r1=176886&r2=176887&view=diff" target="_blank" class="">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticGroups.td?rev=176887&r1=176886&r2=176887&view=diff</a><br class="">
==============================================================================<br class="">
--- cfe/trunk/include/clang/Basic/DiagnosticGroups.td (original)<br class="">
+++ cfe/trunk/include/clang/Basic/DiagnosticGroups.td Tue Mar 12 14:39:19 2013<br class="">
@@ -303,8 +303,6 @@ def ImplicitAtomic : DiagGroup<"implicit<br class="">
def CustomAtomic : DiagGroup<"custom-atomic-properties">;<br class="">
def AtomicProperties : DiagGroup<"atomic-properties",<br class="">
[ImplicitAtomic, CustomAtomic]>;<br class="">
-// FIXME: Remove arc-abi once an Xcode is released that doesn't pass this flag.<br class="">
-def : DiagGroup<"arc-abi">;<br class="">
def ARCUnsafeRetainedAssign : DiagGroup<"arc-unsafe-retained-assign">;<br class="">
def ARCRetainCycles : DiagGroup<"arc-retain-cycles">;<br class="">
def ARCNonPodMemAccess : DiagGroup<"arc-non-pod-memaccess">;<br class="">
<br class="">
Modified: cfe/trunk/test/Driver/warning-options.cpp<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/warning-options.cpp?rev=176887&r1=176886&r2=176887&view=diff" target="_blank" class="">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/warning-options.cpp?rev=176887&r1=176886&r2=176887&view=diff</a><br class="">
==============================================================================<br class="">
--- cfe/trunk/test/Driver/warning-options.cpp (original)<br class="">
+++ cfe/trunk/test/Driver/warning-options.cpp Tue Mar 12 14:39:19 2013<br class="">
@@ -3,11 +3,6 @@<br class="">
// RUN: %clang -### -Wlarge-by-value-copy=128 %s 2>&1 | FileCheck -check-prefix=LARGE_VALUE_COPY_JOINED %s<br class="">
// LARGE_VALUE_COPY_JOINED: -Wlarge-by-value-copy=128<br class="">
<br class="">
-// FIXME: Remove this together with -Warc-abi once an Xcode is released that doesn't pass this flag.<br class="">
-// RUN: %clang -### -Warc-abi -Wno-arc-abi %s 2>&1 | FileCheck -check-prefix=ARCABI %s<br class="">
-// ARCABI-NOT: unknown warning option '-Warc-abi'<br class="">
-// ARCABI-NOT: unknown warning option '-Wno-arc-abi'<br class="">
-<br class="">
// Check that -isysroot warns on nonexistent paths.<br class="">
// RUN: %clang -### -c -target i386-apple-darwin10 -isysroot /FOO %s 2>&1 | FileCheck --check-prefix=CHECK-ISYSROOT %s<br class="">
// CHECK-ISYSROOT: warning: no such sysroot directory: '{{([A-Za-z]:.*)?}}/FOO'<br class="">
<br class="">
<br class="">
_______________________________________________<br class="">
cfe-commits mailing list<br class="">
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank" class="">cfe-commits@cs.uiuc.edu</a><br class="">
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank" class="">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br class="">
</blockquote></div><br class=""></div>
</blockquote></div><br class=""></div></div></blockquote></div><br class=""></div></div></div></div></blockquote></div><br class=""></div></div>
</div></blockquote></div><br class=""></div></body></html>