Did you abandon the revision on purpose? I'm also not understanding the fix quite yet... which test did break before?<br><br><div class="gmail_quote">On Sun Nov 23 2014 at 9:07:00 PM Daniel Cheng <<a href="mailto:dcheng@google.com">dcheng@google.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Rename skipEscapeCharacter() to skipEscapeForDoubleQuote().<br>
<br>
<a href="http://reviews.llvm.org/D6376" target="_blank">http://reviews.llvm.org/D6376</a><br>
<br>
Files:<br>
  lib/Tooling/<u></u>JSONCompilationDatabase.cpp<br>
  unittests/Tooling/<u></u>CompilationDatabaseTest.cpp<br>
</blockquote></div>