<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Fri, Nov 21, 2014 at 3:56 PM, David Majnemer <span dir="ltr"><<a href="mailto:david.majnemer@gmail.com" target="_blank">david.majnemer@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: majnemer<br>
Date: Fri Nov 21 17:56:50 2014<br>
New Revision: 222591<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=222591&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=222591&view=rev</a><br>
Log:<br>
MS ABI: Mangle u8 string literals<br>
<br>
UTF8 string literals are mangled just like ASCII string literals.<br>
<br>
Modified:<br>
    cfe/trunk/lib/AST/MicrosoftMangle.cpp<br>
    cfe/trunk/test/CodeGenCXX/mangle-ms-string-literals.cpp<br>
<br>
Modified: cfe/trunk/lib/AST/MicrosoftMangle.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/MicrosoftMangle.cpp?rev=222591&r1=222590&r2=222591&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/MicrosoftMangle.cpp?rev=222591&r1=222590&r2=222591&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/AST/MicrosoftMangle.cpp (original)<br>
+++ cfe/trunk/lib/AST/MicrosoftMangle.cpp Fri Nov 21 17:56:50 2014<br>
@@ -338,7 +338,8 @@ bool MicrosoftMangleContextImpl::shouldM<br>
<br>
 bool<br>
 MicrosoftMangleContextImpl::shouldMangleStringLiteral(const StringLiteral *SL) {<br>
-  return SL->isAscii() || SL->isWide() || SL->isUTF16() || SL->isUTF32();<br>
+  return SL->isAscii() || SL->isWide() || SL->isUTF8() || SL->isUTF16() ||<br>
+         SL->isUTF32();<br>
 }<br></blockquote><div><br></div><div>Looks like "return true;" to me.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
 void MicrosoftCXXNameMangler::mangle(const NamedDecl *D, StringRef Prefix) {<br>
<br>
Modified: cfe/trunk/test/CodeGenCXX/mangle-ms-string-literals.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/mangle-ms-string-literals.cpp?rev=222591&r1=222590&r2=222591&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/mangle-ms-string-literals.cpp?rev=222591&r1=222590&r2=222591&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/test/CodeGenCXX/mangle-ms-string-literals.cpp (original)<br>
+++ cfe/trunk/test/CodeGenCXX/mangle-ms-string-literals.cpp Fri Nov 21 17:56:50 2014<br>
@@ -719,6 +719,8 @@ const wchar_t *LongWideString = L"012345<br>
 // CHECK: @"\01??_C@_1EK@KFPEBLPK@?$AA0?$AA1?$AA2?$AA3?$AA4?$AA5?$AA6?$AA7?$AA8?$AA9?$AA0?$AA1?$AA2?$AA3?$AA4?$AA5?$AA6?$AA7?$AA8?$AA9?$AA0?$AA1?$AA2?$AA3?$AA4?$AA5?$AA6?$AA7?$AA8?$AA9?$AAA?$AAB@"<br>
 const wchar_t *UnicodeLiteral = L"\ud7ff";<br>
 // CHECK: @"\01??_C@_13IIHIAFKH@?W?$PP?$AA?$AA@"<br>
+const char *U8Literal = u8"hi";<br>
+// CHECK: @"\01??_C@_02PCEFGMJL@hi?$AA@"<br>
 const char16_t *U16Literal = u"hi";<br>
 // CHECK: @"\01??_C@_05OMLEGLOC@h?$AAi?$AA?$AA?$AA@"<br>
 const char32_t *U32Literal = U"hi";<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div></div>