<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Nov 17, 2014, at 7:18 AM, Timur Iskhodzhanov <<a href="mailto:timurrrr@google.com" class="">timurrrr@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">Hi,<br class=""><br class="">This has broken our -Werror internal build.<div class="">One specific thing that I consider a [noisy] false positive:</div><div class=""><br class=""></div><div class="">#define MY_ASSERT(cond) ((cond)? (void)0 : blah)</div><div class="">#define BUG(description) MY_ASSERT(!description)</div><div class="">...</div><div class="">if (some_condition)</div><div class=""> BUG("oh this is broken")<br class=""></div></div></blockquote></div><br class=""><div class=""><br class=""></div><div class="">I cannot reproduce this warning. This is the test I used:</div><div class=""><br class=""></div><div class=""><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class="">#define MY_ASSERT(cond) ((cond)? (void)0 : (void)1)</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class="">#define BUG(description) MY_ASSERT(!description)</div><div style="margin: 0px; font-size: 11px; font-family: Menlo; min-height: 13px;" class=""><br class=""></div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class="">void foo (int some_condition)</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class="">{</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class=""> if (some_condition)</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class=""> BUG("oh this is broken");</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class="">}</div></div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class=""><br class=""></div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class="">Can you give a test case producing the warning?</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class=""><br class=""></div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class="">- Fariborz</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class=""><br class=""></div></body></html>