<div dir="ltr">LGTM<div><br></div><div>There's a good chance we'll bump the version of __has_cpp_attribute(deprecated) in the next revision of SD-6, and we'll probably want to say "you get the new version only in C++1z mode" when we do so. No need to add support for this just yet, but it's something we'll need to think about.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Nov 13, 2014 at 2:47 PM, Aaron Ballman <span dir="ltr"><<a href="mailto:aaron@aaronballman.com" target="_blank">aaron@aaronballman.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This patch should complete our support for the SD-6 standing document,<br>
based off N4200<br>
(<a href="http://www.open-std.org/JTC1/SC22/WG21/docs/papers/2014/n4200.htm" target="_blank">http://www.open-std.org/JTC1/SC22/WG21/docs/papers/2014/n4200.htm</a>).<br>
It implements support for __has_cpp_attribute, based off our existing<br>
support for __has_attribute.<br>
<br>
Note, C++11-style attributes will now be required (by tablegen) to<br>
provide a non-default value for the new Version field, associated with<br>
the attribute spelling. If we decide we want __has_attribute to report<br>
version-specific information for all attributes, we can generalize to<br>
cover that later.<br>
<span class="HOEnZb"><font color="#888888"><br>
~Aaron<br>
</font></span></blockquote></div><br></div>