<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Nov 11, 2014, at 5:03 PM, David Blaikie <<a href="mailto:dblaikie@gmail.com" class="">dblaikie@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><br class=""><div class="gmail_extra"><br class=""><div class="gmail_quote">On Fri, Nov 7, 2014 at 4:06 PM, Ben Langmuir <span dir="ltr" class=""><<a href="mailto:blangmuir@apple.com" target="_blank" class="">blangmuir@apple.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: benlangmuir<br class="">
Date: Fri Nov 7 18:06:39 2014<br class="">
New Revision: 221567<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=221567&view=rev" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=221567&view=rev</a><br class="">
Log:<br class="">
Fix unintended fallthrough in ASTReader<br class=""></blockquote><div class=""><br class="">Is this tested?<br class=""></div></div></div></div></div></blockquote><div><br class=""></div><div class="">No, because there’s no change in behaviour. The garbage data we read in the unintended fallthrough happens to get replaced with the correct data later because of the order we read the blocks.</div><div class=""><br class=""></div><div class="">Thanks for checking :-)</div><div class=""><br class=""></div><div class="">Ben</div><div class=""><br class=""></div><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><div class=""> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br class="">
Modified:<br class="">
cfe/trunk/lib/Serialization/ASTReader.cpp<br class="">
<br class="">
Modified: cfe/trunk/lib/Serialization/ASTReader.cpp<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Serialization/ASTReader.cpp?rev=221567&r1=221566&r2=221567&view=diff" target="_blank" class="">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Serialization/ASTReader.cpp?rev=221567&r1=221566&r2=221567&view=diff</a><br class="">
==============================================================================<br class="">
--- cfe/trunk/lib/Serialization/ASTReader.cpp (original)<br class="">
+++ cfe/trunk/lib/Serialization/ASTReader.cpp Fri Nov 7 18:06:39 2014<br class="">
@@ -2522,6 +2522,8 @@ ASTReader::ReadControlBlock(ModuleFile &<br class="">
if (ASTReadResult Result =<br class="">
ReadModuleMapFileBlock(Record, F, ImportedBy, ClientLoadCapabilities))<br class="">
return Result;<br class="">
+ break;<br class="">
+<br class="">
case INPUT_FILE_OFFSETS:<br class="">
NumInputs = Record[0];<br class="">
NumUserInputs = Record[1];<br class="">
<br class="">
<br class="">
_______________________________________________<br class="">
cfe-commits mailing list<br class="">
<a href="mailto:cfe-commits@cs.uiuc.edu" class="">cfe-commits@cs.uiuc.edu</a><br class="">
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank" class="">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br class="">
</blockquote></div><br class=""></div></div>
</div></blockquote></div><br class=""></body></html>