<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Nov 11, 2014, at 12:16 PM, Richard Trieu <<a href="mailto:rtrieu@google.com">rtrieu@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr">Fariborz,<div><br></div><div>I did not see any of the issues I brought up in the previous email being addressed by r221702</div></div></blockquote><div><br></div>My apology, I forgot to mention. This patch simply provides a functionality in c that c++ already provides. It </div><div>issues a warning when a logical expression evaluates to ‘true’ at compile time. I changed course </div><div>in this new patch. Can you review patch in its current form?</div><div><br></div><div>- Thanks, Fariborz</div><div><br><blockquote type="cite"><div dir="ltr"><div><br></div><div>Richard</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Nov 11, 2014 at 11:53 AM, jahanian <span dir="ltr"><<a href="mailto:fjahanian@apple.com" target="_blank">fjahanian@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; position: static; z-index: auto;"><div style="word-wrap:break-word">I checked a revised patch in r<span style="font-family:Menlo;font-size:11px">221702. Please review post-commit.</span><div><font face="Menlo"><span style="font-size:11px"><br></span></font></div><div><font face="Menlo"><span style="font-size:11px">- Fariborz</span></font></div><div><font face="Menlo"><span style="font-size:11px"><br></span></font><div><div><div class="h5"><div>On Oct 24, 2014, at 2:08 PM, jahanian <<a href="mailto:fjahanian@apple.com" target="_blank">fjahanian@apple.com</a>> wrote:</div><br></div></div><blockquote type="cite"><div><div class="h5"><div style="word-wrap:break-word">Minor change. I should not bail out early when types of implicit cast and its sub expression are identical as<div>implicit cast may be for lvalue to rvalue conversion. This showed up for this test case (with old patch warning is not being issued).</div><div><br></div><div><div style="margin:0px;font-size:11px;font-family:Menlo">__attribute__((__nonnull__))</div><div style="margin:0px;font-size:11px;font-family:Menlo">void test1(void *nonnull) {</div><div style="margin:0px;font-size:11px;font-family:Menlo"> if (nonnull) {}</div><div style="margin:0px;font-size:11px;font-family:Menlo">}</div><div style="margin:0px;font-size:11px;font-family:Menlo"></div></div></div></div></div><span><nonnull-patch-2.txt></span><div style="word-wrap:break-word"><div style="margin:0px;font-size:11px;font-family:Menlo"></div><div style="margin:0px;font-size:11px;font-family:Menlo"><br></div><div style="margin:0px;font-size:11px;font-family:Menlo">- Fariborz</div><div style="margin:0px;font-size:11px;font-family:Menlo"><br></div><div><blockquote type="cite"><span class=""><div>On Oct 24, 2014, at 1:23 PM, jahanian <<a href="mailto:fjahanian@apple.com" target="_blank">fjahanian@apple.com</a>> wrote:</div><br></span><div><span class=""><div style="word-wrap:break-word">Thanks for the review. Here is the updated patch.<div><br></div><div><span style="white-space:pre-wrap"> </span></div></div></span><span><nonnull-patch.txt></span><div style="word-wrap:break-word"><div></div><div><br></div><div>- Fariborz</div><div><br></div></div></div></blockquote></div><br></div><span class="">_______________________________________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br></span></blockquote></div><br></div></div></blockquote></div><br></div>
</blockquote></div><br></body></html>