<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">I checked a revised patch in r<span style="font-family: Menlo; font-size: 11px;">221702. Please review post-commit.</span><div><font face="Menlo"><span style="font-size: 11px;"><br></span></font></div><div><font face="Menlo"><span style="font-size: 11px;">- Fariborz</span></font></div><div><font face="Menlo"><span style="font-size: 11px;"><br></span></font><div><div>On Oct 24, 2014, at 2:08 PM, jahanian <<a href="mailto:fjahanian@apple.com">fjahanian@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><meta http-equiv="Content-Type" content="text/html charset=us-ascii"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Minor change. I should not bail out early when types of implicit cast and its sub expression are identical as<div class="">implicit cast may be for lvalue to rvalue conversion. This showed up for this test case (with old patch warning is not being issued).</div><div class=""><br class=""></div><div class=""><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class="">__attribute__((__nonnull__))</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class="">void test1(void *nonnull) {</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class=""> if (nonnull) {}</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class="">}</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class=""></div></div></div><span><nonnull-patch-2.txt></span><meta http-equiv="Content-Type" content="text/html charset=us-ascii"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class=""><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class=""></div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class=""><br class=""></div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class="">- Fariborz</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class=""><br class=""></div><div><blockquote type="cite" class=""><div class="">On Oct 24, 2014, at 1:23 PM, jahanian <<a href="mailto:fjahanian@apple.com" class="">fjahanian@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Thanks for the review. Here is the updated patch.<div class=""><br class=""></div><div class=""><span class="Apple-tab-span" style="white-space:pre"> </span></div></div><span id="cid:904A0793-6C6E-400D-A132-A24C18467912@apple.com"><nonnull-patch.txt></span><meta http-equiv="Content-Type" content="text/html charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class=""></div><div class=""><br class=""></div><div class="">- Fariborz</div><div class=""><br class=""></div></div></div></blockquote></div><br class=""></div></div>_______________________________________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits<br></blockquote></div><br></div></body></html>