<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Nov 11, 2014 at 5:23 PM, Ben Langmuir <span dir="ltr"><<a href="mailto:blangmuir@apple.com" target="_blank">blangmuir@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><br><div><span class=""><blockquote type="cite"><div>On Nov 11, 2014, at 5:03 PM, David Blaikie <<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>> wrote:</div><br><div><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Nov 7, 2014 at 4:06 PM, Ben Langmuir <span dir="ltr"><<a href="mailto:blangmuir@apple.com" target="_blank">blangmuir@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: benlangmuir<br>
Date: Fri Nov  7 18:06:39 2014<br>
New Revision: 221567<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=221567&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=221567&view=rev</a><br>
Log:<br>
Fix unintended fallthrough in ASTReader<br></blockquote><div><br>Is this tested?<br></div></div></div></div></div></blockquote><div><br></div></span><div>No, because there’s no change in behaviour.  The garbage data we read in the unintended fallthrough happens to get replaced with the correct data later because of the order we read the blocks.</div><div><br></div><div>Thanks for checking :-)</div></div></div></blockquote><div><br>Thanks for the explanation (:<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div><span class="HOEnZb"><font color="#888888"><div><br></div><div>Ben</div></font></span><span class=""><div><br></div><blockquote type="cite"><div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Modified:<br>
    cfe/trunk/lib/Serialization/ASTReader.cpp<br>
<br>
Modified: cfe/trunk/lib/Serialization/ASTReader.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Serialization/ASTReader.cpp?rev=221567&r1=221566&r2=221567&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Serialization/ASTReader.cpp?rev=221567&r1=221566&r2=221567&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/Serialization/ASTReader.cpp (original)<br>
+++ cfe/trunk/lib/Serialization/ASTReader.cpp Fri Nov  7 18:06:39 2014<br>
@@ -2522,6 +2522,8 @@ ASTReader::ReadControlBlock(ModuleFile &<br>
       if (ASTReadResult Result =<br>
               ReadModuleMapFileBlock(Record, F, ImportedBy, ClientLoadCapabilities))<br>
         return Result;<br>
+      break;<br>
+<br>
     case INPUT_FILE_OFFSETS:<br>
       NumInputs = Record[0];<br>
       NumUserInputs = Record[1];<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div></div>
</div></blockquote></span></div><br></div></blockquote></div><br></div></div>