<html><body>
<p><font size="2" face="sans-serif">Hi Rafael,</font><br>
<br>
<tt><font size="2">Rafael Espíndola <rafael.espindola@gmail.com> wrote on 11/07/2014 12:25:36 PM:<br>
<br>
> From: Rafael Espíndola <rafael.espindola@gmail.com></font></tt><br>
<tt><font size="2">> To: Samuel F Antao/Watson/IBM@IBMUS</font></tt><br>
<tt><font size="2">> Cc: llvm cfe <cfe-commits@cs.uiuc.edu></font></tt><br>
<tt><font size="2">> Date: 11/07/2014 12:25 PM</font></tt><br>
<tt><font size="2">> Subject: Re: [PATCH] Fix clash of gcc toolchains in hexagon driver <br>
> regression tests</font></tt><br>
<tt><font size="2">> <br>
> + std::string gcc_toolchain = getGCCToolchainDir(Args);<br>
> <br>
> There is talk of using this style of variable names, but for now we<br>
> are still with CamelCase for variables.<br>
> <br>
> LGTM with the variable name changed.</font></tt><br>
<br>
<tt><font size="2">I've fixed the variable name. Committed in r221535.</font></tt><br>
<br>
<tt><font size="2">Thanks again,</font></tt><br>
<tt><font size="2">Samuel</font></tt><br>
<tt><font size="2"><br>
> <br>
> <br>
> On 6 November 2014 18:37, Samuel F Antao <sfantao@us.ibm.com> wrote:<br>
> > Hi Rafael,<br>
> ><br>
> > Sorry about that. Not sure what I did wrong... Find attached the new patch.<br>
> > I doubled-checked this time.<br>
> ><br>
> > Thanks!<br>
> > Samuel<br>
> ><br>
> > (See attached file: clang_hexagon_fix.patch)<br>
> ><br>
> > Rafael Espíndola <rafael.espindola@gmail.com> wrote on 11/05/2014 05:40:07<br>
> > PM:<br>
> ><br>
> >> From: Rafael Espíndola <rafael.espindola@gmail.com><br>
> >> To: Samuel F Antao/Watson/IBM@IBMUS<br>
> >> Cc: llvm cfe <cfe-commits@cs.uiuc.edu><br>
> >> Date: 11/05/2014 05:40 PM<br>
> >> Subject: Re: [PATCH] Fix clash of gcc toolchains in hexagon driver<br>
> >> regression tests<br>
> >><br>
> >> On 5 November 2014 16:29, Samuel F Antao <sfantao@us.ibm.com> wrote:<br>
> >> > Hi Rafael,<br>
> >> ><br>
> >> > Thanks for the review. I followed your suggestion and used<br>
> >> > getGCCToolchainDir instead. git-clang-format seems not to complainabout<br>
> >> > any<br>
> >> > issues now.<br>
> >><br>
> >> That is odd. Running "git-clang-format master" after applying your<br>
> >> patch to a branch produces the attached patch.<br>
> >><br>
> >> Cheers,<br>
> >> Rafael<br>
> >> [attachment "t.patch" deleted by Samuel F Antao/Watson/IBM]<br>
> <br>
</font></tt></body></html>