<html><body>
<p><font size="2" face="sans-serif">Hi Rafael,</font><br>
<br>
<font size="2" face="sans-serif">Thanks for the review. I followed your suggestion and used </font><tt><font size="2">getGCCToolchainDir</font></tt><font size="2" face="sans-serif"> instead. git-clang-format seems not to complain about any issues now.</font><br>
<br>
<font size="2" face="sans-serif">The new patch is attached.</font><br>
<br>
<font size="2" face="sans-serif">Thanks again!</font><br>
<font size="2" face="sans-serif">Samuel</font><br>
<br>
<i>(See attached file: clang_hexagon_fix.patch)</i><br>
<br>
<tt><font size="2">Rafael Espíndola <rafael.espindola@gmail.com> wrote on 11/01/2014 01:39:16 AM:<br>
<br>
> From: Rafael Espíndola <rafael.espindola@gmail.com></font></tt><br>
<tt><font size="2">> To: Samuel F Antao/Watson/IBM@IBMUS</font></tt><br>
<tt><font size="2">> Cc: llvm cfe <cfe-commits@cs.uiuc.edu></font></tt><br>
<tt><font size="2">> Date: 11/01/2014 01:39 AM</font></tt><br>
<tt><font size="2">> Subject: Re: [PATCH] Fix clash of gcc toolchains in hexagon driver <br>
> regression tests</font></tt><br>
<tt><font size="2">> <br>
> + std::string gcc_toolchain( (A) ? A->getValue() : GCC_INSTALL_PREFIX);<br>
> +<br>
> + if ( !gcc_toolchain.empty() )<br>
> + return gcc_toolchain;<br>
> <br>
> <br>
> You don't need the () in (A). The formatting is wrong, pleas run<br>
> git-clang-format to format the patch. Even better, can't you just use<br>
> getGCCToolchainDir?<br>
> <br>
> <br>
> On 3 October 2014 17:03, Samuel F Antao <sfantao@us.ibm.com> wrote:<br>
> > Ping!<br>
> ><br>
> > 2014-09-10 19:11 GMT-04:00 Samuel F Antao <sfantao@us.ibm.com>:<br>
> >><br>
> >> Hi all,<br>
> >><br>
> >> The driver regression tests for the hexagon target rely on the<br>
> >> minimal/dummy toolchain that comes in the Inputs folder included in the<br>
> >> clang driver tests’s folder. The path to the right toolchain is specified<br>
> >> using the -ccc-install-dir switch. However, if clang was configured with a<br>
> >> custom gcc toolchain (either by using GCC_INSTALL_PREFIX in cmake or the<br>
> >> equivalent configure command), the path to the custom gcc toolchain path<br>
> >> takes precedence to the one specified by -ccc-install-dir. This causes<br>
> >> several regression tests to fail as they will be using an unexpected path.<br>
> >> Adding the switch --gcc-toolchain=“” in each test command is not enough as<br>
> >> the hexagon toolchain implementation in the driver is not evaluating this<br>
> >> argument.<br>
> >><br>
> >> This patch modifies the hexagon toolchain to take the --gcc-toolchain=“”<br>
> >> argument into account when deciding the toolchain path, similarlyto what is<br>
> >> already done for other targets’ toolchains. Additionally, the faulty<br>
> >> regression tests are modified in order to --gcc-toolchain=“” be passed to<br>
> >> the commands.<br>
> >><br>
> >> The modified files are the following:<br>
> >><br>
> >> lib/Driver/ToolChains.cpp<br>
> >> lib/Driver/ToolChains.h<br>
> >> lib/Driver/Tools.cpp<br>
> >> test/Driver/hexagon-toolchain-elf.c<br>
> >> test/Driver/hexagon-toolchain.c<br>
> >><br>
> >> Thanks,<br>
> >><br>
> >> Sam<br>
> >><br>
> >> (See attached file: clang_hexagon_toolchain.patch)<br>
> >><br>
> >><br>
> >> _______________________________________________<br>
> >> cfe-commits mailing list<br>
> >> cfe-commits@cs.uiuc.edu<br>
> >> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
> >><br>
> ><br>
> ><br>
> > _______________________________________________<br>
> > cfe-commits mailing list<br>
> > cfe-commits@cs.uiuc.edu<br>
> > <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
> ><br>
> <br>
</font></tt></body></html>