<div dir="ltr">It's helpful to either use an enum (which always seems a bit silly) or a comment (more realistic, especially since you only have to comment that single caller in attemptRecovery) to describe what the boolean value is for ("/*AcceptInvalidDecl*/ true").<br><br>What's this flag needed/used for?</div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Oct 29, 2014 at 12:49 PM, Kaelyn Takata <span dir="ltr"><<a href="mailto:rikka@google.com" target="_blank">rikka@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">---<br>
 include/clang/Sema/Sema.h |  6 ++++--<br>
 lib/Sema/SemaExpr.cpp     | 15 ++++++++-------<br>
 lib/Sema/SemaExprCXX.cpp  |  2 +-<br>
 3 files changed, 13 insertions(+), 10 deletions(-)<br>
<br>
<br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br></div>