<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Nov 4, 2014 at 10:57 AM, Justin Bogner <span dir="ltr"><<a href="mailto:mail@justinbogner.com" target="_blank">mail@justinbogner.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span class="">Alexander Kornienko <<a href="mailto:alexfh@google.com">alexfh@google.com</a>> writes:<br>
> Author: alexfh<br>
> Date: Tue Nov  4 09:25:22 2014<br>
> New Revision: 221272<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=221272&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=221272&view=rev</a><br>
> Log:<br>
> [clang-tidy] Don't print a message if there's no error.<br>
><br>
> Modified:<br>
>     clang-tools-extra/trunk/clang-tidy/ClangTidyOptions.cpp<br>
><br>
> Modified: clang-tools-extra/trunk/clang-tidy/ClangTidyOptions.cpp<br>
> URL:<br>
> <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/ClangTidyOptions.cpp?rev=221272&r1=221271&r2=221272&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/ClangTidyOptions.cpp?rev=221272&r1=221271&r2=221272&view=diff</a><br>
> ==============================================================================<br>
> --- clang-tools-extra/trunk/clang-tidy/ClangTidyOptions.cpp (original)<br>
> +++ clang-tools-extra/trunk/clang-tidy/ClangTidyOptions.cpp Tue Nov  4 09:25:22 2014<br>
> @@ -235,8 +235,9 @@ FileOptionsProvider::TryReadConfigFile(S<br>
>      llvm::ErrorOr<ClangTidyOptions> ParsedOptions =<br>
>          ConfigHandler.second((*Text)->getBuffer());<br>
>      if (!ParsedOptions) {<br>
> -      llvm::errs() << "Error parsing " << ConfigFile << ": "<br>
> -                   << ParsedOptions.getError().message() << "\n";<br>
> +      if (ParsedOptions.getError())<br>
> +        llvm::errs() << "Error parsing " << ConfigFile << ": "<br>
> +                     << ParsedOptions.getError().message() << "\n";<br>
<br>
</span>This is totally wrong. ErrorOr's implicit bool conversion is true iff<br>
there is an error,</blockquote><div><br>Doesn't look like it:<br><br>ErrorOr.h:<br><div>  /// \brief Return false if there is an error.</div><div>  LLVM_EXPLICIT operator bool() const {</div><div>    return !HasError;</div><div>  }</div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"> so !ParsedOptions implies !ParsedOptions.getError().<br>
<br>
I think you want:<br>
<span class=""><br>
  llvm::ErrorOr<ClangTidyOptions> ParsedOptions =<br>
      ConfigHandler.second((*Text)->getBuffer());<br>
</span>  if (ParsedOptions) {<br>
<span class="">    llvm::errs() << "Error parsing " << ConfigFile << ": "<br>
</span>                 << ParsedOptions.getError().message() << "\n";<br>
    ...<br>
<br>
This obviously changes the behaviour, but the current behaviour doesn't<br>
make sense.<br>
<div class=""><div class="h5"><br>
>        continue;<br>
>      }<br>
><br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div><br></div></div>