<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Oct 24, 2014 at 9:31 AM, Benjamin Kramer <span dir="ltr"><<a href="mailto:benny.kra@googlemail.com" target="_blank">benny.kra@googlemail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Author: d0k<br>
Date: Fri Oct 24 11:31:42 2014<br>
New Revision: 220569<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=220569&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=220569&view=rev</a><br>
Log:<br>
[Modules] Free modules that failed signature verification.<br>
<br>
The control flow and ownership is weird enough so unique_ptr doesn't help here :(<br></blockquote><div><br>I've had a go at unique_ptrification in <span style="color:rgb(0,0,0)"><a href="http://reviews.llvm.org/D5980">http://reviews.llvm.org/D5980</a> (but yeah, I think I stumbled across this too at some point & decided it was too hard at the time)</span><br> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
Modified:<br>
    cfe/trunk/lib/Serialization/ModuleManager.cpp<br>
<br>
Modified: cfe/trunk/lib/Serialization/ModuleManager.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Serialization/ModuleManager.cpp?rev=220569&r1=220568&r2=220569&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Serialization/ModuleManager.cpp?rev=220569&r1=220568&r2=220569&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/Serialization/ModuleManager.cpp (original)<br>
+++ cfe/trunk/lib/Serialization/ModuleManager.cpp Fri Oct 24 11:31:42 2014<br>
@@ -145,6 +145,7 @@ ModuleManager::addModule(StringRef FileN<br>
         // module is *itself* up to date, but has an out-of-date importer.<br>
         Modules.erase(Entry);<br>
         Chain.pop_back();<br>
+        delete New;<br>
         return OutOfDate;<br>
       }<br>
     }<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div></div>