<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Oct 22, 2014 at 6:03 PM, Richard Smith <span dir="ltr"><<a href="mailto:richard-llvm@metafoo.co.uk" target="_blank">richard-llvm@metafoo.co.uk</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rsmith<br>
Date: Wed Oct 22 20:03:45 2014<br>
New Revision: 220456<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=220456&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=220456&view=rev</a><br>
Log:<br>
Fix covered-switch warning.<br>
<br>
Modified:<br>
    cfe/trunk/lib/Lex/ModuleMap.cpp<br>
<br>
Modified: cfe/trunk/lib/Lex/ModuleMap.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Lex/ModuleMap.cpp?rev=220456&r1=220455&r2=220456&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Lex/ModuleMap.cpp?rev=220456&r1=220455&r2=220456&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/Lex/ModuleMap.cpp (original)<br>
+++ cfe/trunk/lib/Lex/ModuleMap.cpp Wed Oct 22 20:03:45 2014<br>
@@ -2305,6 +2305,7 @@ bool ModuleMapParser::parseModuleMapFile<br>
     case MMToken::RequiresKeyword:<br>
     case MMToken::Star:<br>
     case MMToken::StringLiteral:<br>
+    case MMToken::TextualKeyword:<br></blockquote><div><br></div><div>Probably not, but just checking: is there missing test coverage here? (that would exercise this case in the switch)</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
     case MMToken::UmbrellaKeyword:<br>
     case MMToken::UseKeyword:<br>
       Diags.Report(Tok.getLocation(), diag::err_mmap_expected_module);<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div></div>