<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Makes sense, updated patch attached.<br>
Thx, Steve<br>
<br>
<div class="moz-cite-prefix">On 10/17/2014 06:45 PM, Eric Fiselier
wrote:<br>
</div>
<blockquote
cite="mid:CAB=TDAW32H=a9sSY-J4vVsOqpebe8-R-UnGHV5yj=dqutxikJA@mail.gmail.com"
type="cite">
<div dir="ltr">Hi Steve,
<div><br>
</div>
<div>It seems most of the changes just remove unused variables
after they are initialized. Isn't the initialization part of
the test?</div>
<div>For example, if the return type of `foo()` is specified to
be a type that is BooleanConvertible then doesn't it make
sense to test `bool unused = foo()`?</div>
<div>I would rather just see the variables be used as opposed to
their ommision. Even if using them just means
`((void)unused)`.</div>
<div><br>
</div>
<div>/Eric </div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Fri, Oct 17, 2014 at 7:24 PM, Steve
MacKenzie <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:stevemac321@live.com" target="_blank">stevemac321@live.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">I am about
half-way through running the libc++ tests with scan-build.
I thought it good to submit a patch now for review for
feedback rather than later.<br>
<br>
All the bugs are of the "dead initialization" category. I
tried to apply the least intrusive fix as possible, which in
all but a couple cases, involved simply removing the unused
lvalue from the statement. So the coverage should remain
the same, neither augmented nor diminished.<br>
<br>
I did encounter one scan-build false positive, it looks to
have been reported already (10862). I added a very simple
repro to the bug report. (I thought about adding a comment
in these tests referencing the bug 10862, but did not, let
me know if I should).<br>
<br>
The status of the run is being tracked on my blog here:<br>
<a moz-do-not-send="true"
href="http://stevemac123.wordpress.com/static-analysis-run/"
target="_blank">http://stevemac123.wordpress.com/static-analysis-run/</a><br>
<br>
clang version 3.6.0 (trunk 217475)<br>
Target: x86_64-unknown-linux-gnu<br>
Thread model: posix<br>
<br>
Command line used:<br>
<br>
can-build -k -V -analyze-headers clang++ -std=c++1y
-stdlib=libc++<br>
<br>
Thanks,<br>
Steve MacKenzie<br>
<br>
<br>
<br>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</body>
</html>