<div dir="ltr">Generally test cases are committed with the fix - makes it easier when spelunking through revision history (for the code that applies to a fix/test/etc).<br><br>It helps to mention the reason a test is omitted (urgency, test case reduction is difficult, etc) and whether one will be forthcoming in the commit message.<br><br>If you could reply to this review thread with the revision where the test is added (when it is added), that'd be great!<br><br>- David</div><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Oct 12, 2014 at 7:45 PM, Bataev, Alexey <span dir="ltr"><<a href="mailto:a.bataev@hotmail.com" target="_blank">a.bataev@hotmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Yes, I'm working on it. Will be ready soon.<br>
<br>
Best regards,<br>
Alexey Bataev<br>
=============<br>
Software Engineer<br>
Intel Compiler Team<br>
<br>
<a href="tel:13.10.2014" value="+13102014" target="_blank">13.10.2014</a> 4:31, David Blaikie пишет:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
<br>
Any chance of a test?<br>
<br></span><div><div class="h5">
On Oct 10, 2014 10:21 PM, "Alexey Bataev" <<a href="mailto:a.bataev@hotmail.com" target="_blank">a.bataev@hotmail.com</a> <mailto:<a href="mailto:a.bataev@hotmail.com" target="_blank">a.bataev@hotmail.com</a>>> wrote:<br>
<br>
    Author: abataev<br>
    Date: Sat Oct 11 00:07:24 2014<br>
    New Revision: 219561<br>
<br>
    URL: <a href="http://llvm.org/viewvc/llvm-project?rev=219561&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=219561&view=rev</a><br>
    Log:<br>
    Fix deserialization of PredefinedExpr in dependent context.<br>
<br>
    Modified:<br>
        cfe/trunk/lib/Serialization/<u></u>ASTReaderStmt.cpp<br>
<br>
    Modified: cfe/trunk/lib/Serialization/<u></u>ASTReaderStmt.cpp<br>
    URL:<br>
    <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Serialization/ASTReaderStmt.cpp?rev=219561&r1=219560&r2=219561&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/cfe/trunk/lib/<u></u>Serialization/ASTReaderStmt.<u></u>cpp?rev=219561&r1=219560&r2=<u></u>219561&view=diff</a><br>
    ==============================<u></u>==============================<u></u>==================<br>
    --- cfe/trunk/lib/Serialization/<u></u>ASTReaderStmt.cpp (original)<br>
    +++ cfe/trunk/lib/Serialization/<u></u>ASTReaderStmt.cpp Sat Oct 11<br>
    00:07:24 2014<br>
    @@ -423,7 +423,7 @@ void ASTStmtReader::<u></u>VisitPredefinedExpr(<br>
       VisitExpr(E);<br>
       E->setLocation(<u></u>ReadSourceLocation(Record, Idx));<br>
       E->Type = (PredefinedExpr::IdentType)<u></u>Record[Idx++];<br>
    -  E->FnName = cast<StringLiteral>(Reader.<u></u>ReadSubExpr());<br>
    +  E->FnName = cast_or_null<StringLiteral>(<u></u>Reader.ReadSubExpr());<br>
     }<br>
<br>
     void ASTStmtReader::<u></u>VisitDeclRefExpr(DeclRefExpr *E) {<br>
<br>
<br>
    ______________________________<u></u>_________________<br>
    cfe-commits mailing list<br></div></div>
    <a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a> <mailto:<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.<u></u>edu</a>><br>
    <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/cfe-commits</a><br>
<br>
</blockquote>
<br>
</blockquote></div><br></div>