<p dir="ltr">Not sure what you are getting at.. It is obviously wrong, but this is about probabilities.. </p>
<div class="gmail_quote">On Oct 6, 2014 9:32 PM, "Justin Bogner" <<a href="mailto:mail@justinbogner.com">mail@justinbogner.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Daniel Jasper <<a href="mailto:djasper@google.com">djasper@google.com</a>> writes:<br>
> Author: djasper<br>
> Date: Mon Oct  6 08:16:43 2014<br>
> New Revision: 219119<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=219119&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=219119&view=rev</a><br>
> Log:<br>
> clang-format: If in doubt, assume '+' is a binary operator.<br>
><br>
> Before:<br>
>   #define LENGTH(x, y) (x) - (y)+1<br>
><br>
> After:<br>
>   #define LENGTH(x, y) (x) - (y) + 1<br>
<br>
What about this one?<br>
<br>
    #define LENGTH(x, y) (x) - (y) - 1<br>
<br>
> Modified:<br>
>     cfe/trunk/lib/Format/TokenAnnotator.cpp<br>
>     cfe/trunk/unittests/Format/FormatTest.cpp<br>
><br>
> Modified: cfe/trunk/lib/Format/TokenAnnotator.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Format/TokenAnnotator.cpp?rev=219119&r1=219118&r2=219119&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Format/TokenAnnotator.cpp?rev=219119&r1=219118&r2=219119&view=diff</a><br>
> ==============================================================================<br>
> --- cfe/trunk/lib/Format/TokenAnnotator.cpp (original)<br>
> +++ cfe/trunk/lib/Format/TokenAnnotator.cpp Mon Oct  6 08:16:43 2014<br>
> @@ -902,8 +902,9 @@ private:<br>
>          if (Prev && Tok.Next && Tok.Next->Next) {<br>
>            bool NextIsUnary = Tok.Next->isUnaryOperator() ||<br>
>                               Tok.Next->isOneOf(tok::amp, tok::star);<br>
> -          IsCast = NextIsUnary && Tok.Next->Next->isOneOf(<br>
> -                                      tok::identifier, tok::numeric_constant);<br>
> +          IsCast =<br>
> +              NextIsUnary && !Tok.Next->is(tok::plus) &&<br>
> +              Tok.Next->Next->isOneOf(tok::identifier, tok::numeric_constant);<br>
>          }<br>
><br>
>          for (; Prev != Tok.MatchingParen; Prev = Prev->Previous) {<br>
><br>
> Modified: cfe/trunk/unittests/Format/FormatTest.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/Format/FormatTest.cpp?rev=219119&r1=219118&r2=219119&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/Format/FormatTest.cpp?rev=219119&r1=219118&r2=219119&view=diff</a><br>
> ==============================================================================<br>
> --- cfe/trunk/unittests/Format/FormatTest.cpp (original)<br>
> +++ cfe/trunk/unittests/Format/FormatTest.cpp Mon Oct  6 08:16:43 2014<br>
> @@ -5116,6 +5116,7 @@ TEST_F(FormatTest, FormatsCasts) {<br>
>    verifyFormat("my_int a = (my_int)sizeof(int);");<br>
>    verifyFormat("return (my_int)aaa;");<br>
>    verifyFormat("#define x ((int)-1)");<br>
> +  verifyFormat("#define LENGTH(x, y) (x) - (y) + 1");<br>
>    verifyFormat("#define p(q) ((int *)&q)");<br>
>    verifyFormat("fn(a)(b) + 1;");<br>
><br>
> @@ -5123,7 +5124,7 @@ TEST_F(FormatTest, FormatsCasts) {<br>
>    verifyFormat("void f() { return P ? (my_int)*P : (my_int)0; }");<br>
>    verifyFormat("my_int a = (my_int)~0;");<br>
>    verifyFormat("my_int a = (my_int)++a;");<br>
> -  verifyFormat("my_int a = (my_int)+2;");<br>
> +  verifyFormat("my_int a = (my_int)-2;");<br>
>    verifyFormat("my_int a = (my_int)1;");<br>
>    verifyFormat("my_int a = (my_int *)1;");<br>
>    verifyFormat("my_int a = (const my_int)-1;");<br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>