<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Sep 30, 2014, at 2:45 PM, Reid Kleckner <<a href="mailto:rnk@google.com">rnk@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr"><div>+def CXX11WarnOverrideMethod : DiagGroup<"warn-missing-override-on-overriding-method">;</div><div><br></div><div>Anyone care to bikeshed the name a bit? This flag feels really verbose, especially given that it gets a -W prefix.</div><div><br></div><div>Can we go with -Wmissing-override or -Winconsistent-missing-override to reflect the fact that it's heuristically triggered based on use of C++11 override somewhere in the class hierarchy?</div></div></blockquote><div><br></div>I selected your suggestion of -Winconsistent-missing-override. I think I have covered everything else and</div><div>Doug responded to some of your comments let me know if I missed anything.</div><div><br></div><div>In r<span style="font-family: Menlo; font-size: 11px;">218925.</span></div><div><span style="font-family: Menlo; font-size: 11px;">- Fariborz</span></div><div><span style="font-family: Menlo; font-size: 11px;"><br></span></div><div><blockquote type="cite"><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Sep 26, 2014 at 4:15 PM, jahanian <span dir="ltr"><<a href="mailto:fjahanian@apple.com" target="_blank">fjahanian@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><br><div><div>On Sep 26, 2014, at 4:12 PM, Douglas Gregor <<a href="mailto:dgregor@apple.com" target="_blank">dgregor@apple.com</a>> wrote:</div><br><blockquote type="cite"><div style="word-wrap:break-word">LGTM<div><br></div></div></blockquote>Thanks. I want to add FixIts before checking it in.</div><div><br></div><div>- Fariborz</div><div><div class="h5"><div><br><blockquote type="cite"><div style="word-wrap:break-word"><div><blockquote type="cite"><div>On Sep 26, 2014, at 4:10 PM, jahanian <<a href="mailto:fjahanian@apple.com" target="_blank">fjahanian@apple.com</a>> wrote:</div><br><div><div style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><div><br>On Sep 26, 2014, at 3:37 PM, Douglas Gregor <<a href="mailto:dgregor@apple.com" target="_blank">dgregor@apple.com</a>> wrote:</div><br><blockquote type="cite"><div style="word-wrap:break-word"><br><div><blockquote type="cite"><div>On Sep 26, 2014, at 3:03 PM, jahanian <<a href="mailto:fjahanian@apple.com" target="_blank">fjahanian@apple.com</a>> wrote:</div><br><div><div style="word-wrap:break-word"><br><div><div>On Sep 25, 2014, at 11:51 AM, Argyrios Kyrtzidis <<a href="mailto:kyrtzidis@apple.com" target="_blank">kyrtzidis@apple.com</a>> wrote:</div><br><blockquote type="cite"><div style="word-wrap:break-word"><br><div><blockquote type="cite"><div>On Sep 25, 2014, at 11:24 AM, Douglas Gregor <<a href="mailto:dgregor@apple.com" target="_blank">dgregor@apple.com</a>> wrote:</div><br><div><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important"><span> </span>I’d feel a lot better if some part of the warning could be on by default. For example, if you’ve uttered “override” at least once in a class, it makes sense to warn-by-default about any other overrides in that class that weren’t marked as “override”, because you’re being locally inconsistent. Or maybe you can expand that heuristic out to a file-level granularity (which matches better for the null point constant warning) and still be on-by-default.</span></div></blockquote></div><br><div><div>This seems like a great idea to me!</div><div>For the 'override' I much prefer if it is class specific to make it less of a burden as an “always on” warning. We could have the checking done at the end of the class definition.</div></div><div><br></div></div></blockquote></div><br><div>Here is the patch. Warning is on by default. Number of new warnings on clang tests is greatly reduced but there are still some.</div></div></div></blockquote><br></div><div><div>+def warn_function_marked_not_override_overriding : Warning <</div><div>+ "%0 is not marked 'override' but overrides a member functions">,</div><div>+ InGroup<CXX11WarnOverrideMethod>;</div><div><br></div><div>“a member functions” shouldn’t be plural. Also, perhaps we should turn this around:</div><div><br></div><div><span style="white-space:pre-wrap"> </span>“%0 overrides a member function but is not marked ‘override’”</div><div><br></div><div>because that puts the context of the problem before the problem.</div><div><br></div><div><div>+ if (HasMethodWithOverrideControl) {</div><div>+ // At list one method has the 'override' control declared.</div><div>+ // Diagnose all other overridden methods which do not have 'override' specified on them.</div></div><div>+ for (auto *M : Record->methods())</div><div><br></div><div>“At list” -> “At least”.</div><div><br></div><div>Also, this means we’ll be taking two passes over the methods if any “override” is present, even though we won’t often warn here. How about extending this:</div><div><br></div><div><div>+ if (M->hasAttr<OverrideAttr>())</div><div>+ HasMethodWithOverrideControl = true;</div></div><div><br></div><div>with</div><div><br></div><div><span style="white-space:pre-wrap"> </span>else if (M->begin_overridden_methods() != M->end_overridden_methods())</div><div><span style="white-space:pre-wrap"> </span> HasOverridingMethodWithoutOverrideControl = true;</div><div><br></div><div>and we only do this second pass when we know we’re going to warn, e.g., if HasMethodWithOverrideControl && HasOverridingMethodWithoutOverrideControl?</div></div></div></blockquote><div><br></div>Thanks for quick review. Here is the updated patch.</div><div style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><span style="white-space:pre-wrap"> </span></div><span><override-patch.txt></span><div style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"></div><div style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><br></div><div style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">- Fariborz<br><blockquote type="cite"><div style="word-wrap:break-word"><div><br></div><div><span style="white-space:pre-wrap"> </span>- Doug</div></div></blockquote></div></div></blockquote></div><br></div></blockquote></div><br></div></div></div><br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br></div>
</blockquote></div><br></body></html>