<div dir="ltr">I don't mind either way. This change seems beneficial on its own.</div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Sep 29, 2014 at 5:31 PM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5"><p dir="ltr"><br>
On Sep 26, 2014 8:57 AM, "Renato Golin" <<a href="mailto:renato.golin@linaro.org" target="_blank">renato.golin@linaro.org</a>> wrote:<br>
><br>
> On 16 September 2014 17:22, Daniel Jasper <<a href="mailto:djasper@google.com" target="_blank">djasper@google.com</a>> wrote:<br>
> > +  // For backward compatibility:<br>
> > +  CHECK_PARSE("DerivePointerBinding: true", DerivePointerAlignment, true);<br>
> > +  CHECK_PARSE("DerivePointerBinding: false", DerivePointerAlignment, false);<br>
><br>
> Hi Daniel,<br>
><br>
> GCC 4.9.1 gives me this warning for that last line:<br>
><br>
> src/llvm/tools/clang/unittests/Format/FormatTest.cpp:8387:1132:<br>
> warning: converting ‘false’ to pointer type for argument 1 of ‘char<br>
> testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’<br>
> [-Wconversion-null]<br>
>    CHECK_PARSE("DerivePointerBinding: false", DerivePointerAlignment, false);</p>
</div></div><p dir="ltr">I think we did something smart to suppress clangs warning in this common & benign gunit test case. (Its just trying to teat if something /could/ be a null pointer literal so it doesn't lose that down through some template layers)</p>
<p dir="ltr">Should we just disable gccs version of the warning?</p>
<p dir="ltr">><br>
> cheers,<br>
> --renato<span class=""><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</span></p>
</blockquote></div><br></div>