<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div>Artyom,</div><div><br></div><div>PostgreSQL started timing out or taking a VERY long time. We have a Bulidbot that builds several projects and none of them were timing out before this commit. I don't know the specific revision; but it is PostgreSQL 9.1.</div><div><br></div><div>I suggest reverting this commit and investigating why it causes the regression. Generally, we should come up with a solution that does not take hours on any of the benchmarks.</div><div><br></div><div>Anna.<br><br>Sent from my iPhone</div><div><br>On Sep 20, 2014, at 8:10 AM, Artyom Skrobov <<a href="mailto:Artyom.Skrobov@arm.com">Artyom.Skrobov@arm.com</a>> wrote:<br><br></div><blockquote type="cite"><div><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"><meta name="Generator" content="Microsoft Word 12 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:Menlo;
panose-1:0 0 0 0 0 0 0 0 0 0;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{mso-style-priority:99;
mso-style-link:"Balloon Text Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma","sans-serif";}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.BalloonTextChar
{mso-style-name:"Balloon Text Char";
mso-style-priority:99;
mso-style-link:"Balloon Text";
font-family:"Tahoma","sans-serif";}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--><div class="WordSection1"><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Anna, do you mean the performance had been acceptable after r214064, but degraded after r215650, which fixed the performance regression introduced in r214064?<o:p></o:p></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Do you have any specific example of code that takes longer to compile after r215650?<o:p></o:p></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Not hearing back from Alexander since August, I assumed the performance regression he observed after r215650 was not in fact related to that commit.<o:p></o:p></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p></div></div></blockquote>I suspect it is related.<br><blockquote type="cite"><div><div class="WordSection1"><div><div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm"><p class="MsoNormal"><b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Anna Zaks [<a href="mailto:ganna@apple.com">mailto:ganna@apple.com</a>] <br><b>Sent:</b> 20 September 2014 01:19<br><b>To:</b> Artyom Skrobov<br><b>Cc:</b> <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a> Commits; Ted Kremenek; Jordan Rose; Alexander Kornienko<br><b>Subject:</b> Re: [PATCH] Inverse post-order traversal for LiveVariables analysis, to recover the performance after r214064<o:p></o:p></span></p></div></div><p class="MsoNormal"><o:p> </o:p></p><p class="MsoNormal">Hi Artyom,<o:p></o:p></p><div><p class="MsoNormal"><o:p> </o:p></p></div><div><p class="MsoNormal">Unfortunately, this commit (r215650) causes major performance regressions on our buildbots. In particular, building <span style="font-family:"Menlo","serif"">postgresql-9.1</span> times out.<o:p></o:p></p></div><div><p class="MsoNormal"><o:p> </o:p></p></div><div><p class="MsoNormal">Please, revert as soon as possible.<o:p></o:p></p></div><div><p class="MsoNormal"><o:p> </o:p></p></div><div><p class="MsoNormal">Thank you,<o:p></o:p></p></div><div><p class="MsoNormal">Anna.<o:p></o:p></p><div><blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"><div><p class="MsoNormal">On Aug 20, 2014, at 3:13 AM, Alexander Kornienko <<a href="mailto:alexfh@google.com">alexfh@google.com</a>> wrote:<o:p></o:p></p></div><p class="MsoNormal"><o:p> </o:p></p><div><div><div><div><p class="MsoNormal">On Fri, Aug 15, 2014 at 10:38 AM, Artyom Skrobov <<a href="mailto:Artyom.Skrobov@arm.com" target="_blank">Artyom.Skrobov@arm.com</a>> wrote:<o:p></o:p></p><p class="MsoNormal">Many thanks -- committed as r215650<br><br>Alexander, can you confirm that the analyzer performance is now acceptable<br>for your use cases?<o:p></o:p></p><div><p class="MsoNormal"><o:p> </o:p></p></div><div><p class="MsoNormal">Artyom, sorry for the long delay. These files now work fine, but I still see up to 8-10 hours analysis time on a couple of other files. I'm sure I didn't see this before your first patch, but I can't yet tell in which revision it was introduced. I'll post more details and a repro later today.<o:p></o:p></p></div><div><p class="MsoNormal"> <o:p></o:p></p></div><blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm"><div><p class="MsoNormal" style="margin-bottom:12.0pt"><br><br>-----Original Message-----<br>From: Ted kremenek [mailto:<a href="mailto:kremenek@apple.com">kremenek@apple.com</a>]<br>Sent: 14 August 2014 16:36<br>To: Artyom Skrobov<br>Cc: Alexander Kornienko; <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>Subject: Re: [PATCH] Inverse post-order traversal for LiveVariables<br>analysis, to recover the performance after r214064<o:p></o:p></p></div><div><div><p class="MsoNormal" style="margin-bottom:12.0pt">Looks great to me.<br><br>> On Aug 14, 2014, at 3:08 AM, Artyom Skrobov <<a href="mailto:Artyom.Skrobov@arm.com">Artyom.Skrobov@arm.com</a>><br>wrote:<br>><br>> Thank you Ted!<br>><br>> Attaching the updated patch for a final review.<br>><br>> Summary of changes:<br>><br>> * Comments updated to reflect the two possible CFG traversal orders<br>> * PostOrderCFGView::po_iterator taken out of the header file<br>> * Iteration order for PostOrderCFGView changed to "reverse inverse<br>> post-order", the one required for a backward analysis<br>> * ReversePostOrderCFGView created, with the same iteration order that<br>> PostOrderCFGView used to have, the one required for a forward analysis<br>> * The two previous consumers of PostOrderCFGView, ThreadSafetyCommon.h and<br>> Consumed.cpp, switched to use ReversePostOrderCFGView<br>> * DataflowWorklistBase renamed to DataflowWorklist, and the two<br>> specializations named BackwardDataflowWorklist and ForwardDataflowWorklist<br>><br>> I believe this naming scheme matches the accepted terminology best.<o:p></o:p></p></div></div></blockquote></div></div></div><p class="MsoNormal">_______________________________________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><o:p></o:p></p></div></blockquote></div><p class="MsoNormal"><o:p> </o:p></p></div></div></div></blockquote></body></html>