<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi Artyom,<div class=""><br class=""></div><div class="">Unfortunately, this commit (r215650) causes major performance regressions on our buildbots. In particular, building <span style="font-family: Menlo;" class="">postgresql-9.1</span> times out.</div><div class=""><br class=""></div><div class="">Please, revert as soon as possible.</div><div class=""><br class=""></div><div class="">Thank you,</div><div class="">Anna.<br class=""><div><blockquote type="cite" class=""><div class="">On Aug 20, 2014, at 3:13 AM, Alexander Kornienko <<a href="mailto:alexfh@google.com" class="">alexfh@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote">On Fri, Aug 15, 2014 at 10:38 AM, Artyom Skrobov <span dir="ltr" class=""><<a href="mailto:Artyom.Skrobov@arm.com" target="_blank" class="">Artyom.Skrobov@arm.com</a>></span> wrote:<br class="">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Many thanks -- committed as r215650<br class="">
<br class="">
Alexander, can you confirm that the analyzer performance is now acceptable<br class="">
for your use cases?<br class=""></blockquote><div class=""><br class=""></div><div class="">Artyom, sorry for the long delay. These files now work fine, but I still see up to 8-10 hours analysis time on a couple of other files. I'm sure I didn't see this before your first patch, but I can't yet tell in which revision it was introduced. I'll post more details and a repro later today.</div>
<div class=""> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im HOEnZb"><br class="">
<br class="">
-----Original Message-----<br class="">
From: Ted kremenek [mailto:<a href="mailto:kremenek@apple.com" class="">kremenek@apple.com</a>]<br class="">
Sent: 14 August 2014 16:36<br class="">
To: Artyom Skrobov<br class="">
Cc: Alexander Kornienko; <a href="mailto:cfe-commits@cs.uiuc.edu" class="">cfe-commits@cs.uiuc.edu</a><br class="">
Subject: Re: [PATCH] Inverse post-order traversal for LiveVariables<br class="">
analysis, to recover the performance after r214064<br class="">
<br class="">
</div><div class="HOEnZb"><div class="h5">Looks great to me.<br class="">
<br class="">
> On Aug 14, 2014, at 3:08 AM, Artyom Skrobov <<a href="mailto:Artyom.Skrobov@arm.com" class="">Artyom.Skrobov@arm.com</a>><br class="">
wrote:<br class="">
><br class="">
> Thank you Ted!<br class="">
><br class="">
> Attaching the updated patch for a final review.<br class="">
><br class="">
> Summary of changes:<br class="">
><br class="">
> * Comments updated to reflect the two possible CFG traversal orders<br class="">
> * PostOrderCFGView::po_iterator taken out of the header file<br class="">
> * Iteration order for PostOrderCFGView changed to "reverse inverse<br class="">
> post-order", the one required for a backward analysis<br class="">
> * ReversePostOrderCFGView created, with the same iteration order that<br class="">
> PostOrderCFGView used to have, the one required for a forward analysis<br class="">
> * The two previous consumers of PostOrderCFGView, ThreadSafetyCommon.h and<br class="">
> Consumed.cpp, switched to use ReversePostOrderCFGView<br class="">
> * DataflowWorklistBase renamed to DataflowWorklist, and the two<br class="">
> specializations named BackwardDataflowWorklist and ForwardDataflowWorklist<br class="">
><br class="">
> I believe this naming scheme matches the accepted terminology best.<br class=""><br class=""></div></div></blockquote></div>
</div></div>
_______________________________________________<br class="">cfe-commits mailing list<br class=""><a href="mailto:cfe-commits@cs.uiuc.edu" class="">cfe-commits@cs.uiuc.edu</a><br class="">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits<br class=""></div></blockquote></div><br class=""></div></body></html>