<div dir="ltr">Thank you for review!<div>Committed rev. 218116, 218117, 218118.</div></div><div class="gmail_extra"><br><div class="gmail_quote">2014-09-18 21:13 GMT+04:00 Eric Christopher <span dir="ltr"><<a href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Cool, a comment to that effect in the code would probably be nice.<div><br></div><div>Otherwise LGTM.</div><span class="HOEnZb"><font color="#888888"><div><br></div><div>-eric</div></font></span></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Sep 18, 2014 at 6:14 AM, Robert Khasanov <span dir="ltr"><<a href="mailto:rob.khasanov@gmail.com" target="_blank">rob.khasanov@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Difference between two sets of builtins that _addcarryx can be used only if ADX feature available. Whereas _addcarry and _subborrow can be used w/o ADX CPUID.</div><div>That's why I included "#ifdef __ADX__" line inside adxintrin.h, put _addcarryx intrinsics under #ifdef and other outside #ifdef, finally divided into two patches.</div><div><br></div></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">2014-09-17 21:34 GMT+04:00 Eric Christopher <span dir="ltr"><<a href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div> </div><div>+#include <adxintrin.h></div><div>+</div><div><br></div><div>#ifdef __ADX__ ?</div><div><br></div><div>And any reason the two sets of builtins aren't in the same patch or were you planning on one large commit for this?</div><span><font color="#888888"><div><br></div><div>-eric</div><div><br></div></font></span></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Sep 17, 2014 at 10:30 AM, Reid Kleckner <span dir="ltr"><<a href="mailto:rnk@google.com" target="_blank">rnk@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Clang patches LGTM with some tweaks.<div><br></div><div><div>+// RUN: %clang_cc1 -triple x86_64-unknown-unknown -target-feature +adx -emit-llvm -o - %s | FileCheck %s</div><div>+</div><div>+// Don't include mm_malloc.h, it's system specific.</div><div>+#define __MM_MALLOC_H</div></div><div><br></div><div>You can use the -ffreestanding flag to avoid this quirk, I believe.</div></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Sep 17, 2014 at 1:31 AM, Robert Khasanov <span dir="ltr"><<a href="mailto:rob.khasanov@gmail.com" target="_blank">rob.khasanov@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Ping</div><span>Could anyone review clang patches?</span></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">2014-08-25 15:58 GMT+04:00 Robert Khasanov <span dir="ltr"><<a href="mailto:rob.khasanov@gmail.com" target="_blank">rob.khasanov@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Ping<div><div><br><div class="gmail_extra"><br><br><div class="gmail_quote">2014-08-21 13:53 GMT+04:00 Robert Khasanov <span dir="ltr"><<a href="mailto:rob.khasanov@gmail.com" target="_blank">rob.khasanov@gmail.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Thanks for review, Nadav!<div><br></div><div>Committed rev216161, 216162, 216163, 216164.</div><div><br>
</div><div>Could anyone review clang patches?</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">
2014-08-20 20:41 GMT+04:00 Nadav Rotem <span dir="ltr"><<a href="mailto:nrotem@apple.com" target="_blank">nrotem@apple.com</a>></span>:<div><div><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
The LLVM patches LGTM. Thanks Robert!<br>
<div><div><br>
<br>
> On Aug 20, 2014, at 8:55 AM, Robert Khasanov <<a href="mailto:rob.khasanov@gmail.com" target="_blank">rob.khasanov@gmail.com</a>> wrote:<br>
><br>
> Hi All,<br>
><br>
> These patches enable Broadwell subtarget:<br>
> Broadwell ISA includes Haswell ISA + ADX + RDSEED + SMAP<br>
> New instructions were already enabled. These patches define broadwell cpu, SMAP Feature and add intrinsics to LLVM/clang<br>
</div></div>> <001_llvm_broadwell_target.patch><002_llvm_adox_adcx.patch><003_llvm_smap.patch><004_llvm_adc_sbb.patch><005_clang_broadwell_target.patch><006_clang_adx.patch><007_clang_adc_sbb.patch><br>
<br>
</blockquote></div></div></div><br></div>
</blockquote></div><br></div></div></div></div>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>