<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Thu, Sep 18, 2014 at 10:16 AM, Renato Golin <span dir="ltr"><<a href="mailto:renato.golin@linaro.org" target="_blank">renato.golin@linaro.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Richard,<br>
<br>
Have you had time to look at this?<br>
<br>
<a href="http://lab.llvm.org:8011/builders/clang-native-arm-cortex-a9/builds/21803" target="_blank">http://lab.llvm.org:8011/builders/clang-native-arm-cortex-a9/builds/21803</a></blockquote><div><br></div><div>I was not aware of that. Is the bot misconfigured? It didn't send me any mail. The patch has been reverted; I'll take a look before it goes back in.</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
cheers,<br>
--renato<br>
<div class="HOEnZb"><div class="h5"><br>
On 18 September 2014 01:12, Richard Smith <<a href="mailto:richard-llvm@metafoo.co.uk">richard-llvm@metafoo.co.uk</a>> wrote:<br>
> Author: rsmith<br>
> Date: Wed Sep 17 19:12:09 2014<br>
> New Revision: 217997<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=217997&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=217997&view=rev</a><br>
> Log:<br>
> Skip parens when detecting whether we're instantiating a function declaration.<br>
><br>
> Modified:<br>
>     cfe/trunk/lib/Sema/SemaTemplateInstantiate.cpp<br>
>     cfe/trunk/test/SemaTemplate/instantiate-exception-spec-cxx11.cpp<br>
><br>
> Modified: cfe/trunk/lib/Sema/SemaTemplateInstantiate.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaTemplateInstantiate.cpp?rev=217997&r1=217996&r2=217997&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaTemplateInstantiate.cpp?rev=217997&r1=217996&r2=217997&view=diff</a><br>
> ==============================================================================<br>
> --- cfe/trunk/lib/Sema/SemaTemplateInstantiate.cpp (original)<br>
> +++ cfe/trunk/lib/Sema/SemaTemplateInstantiate.cpp Wed Sep 17 19:12:09 2014<br>
> @@ -1577,8 +1577,8 @@ TypeSourceInfo *Sema::SubstFunctionDeclT<br>
><br>
>    QualType Result;<br>
><br>
> -  // FIXME: What if the function type is parenthesized?<br>
> -  if (FunctionProtoTypeLoc Proto = TL.getAs<FunctionProtoTypeLoc>()) {<br>
> +  if (FunctionProtoTypeLoc Proto =<br>
> +          TL.IgnoreParens().getAs<FunctionProtoTypeLoc>()) {<br>
>      // Instantiate the type, other than its exception specification. The<br>
>      // exception specification is instantiated in InitFunctionInstantiation<br>
>      // once we've built the FunctionDecl.<br>
><br>
> Modified: cfe/trunk/test/SemaTemplate/instantiate-exception-spec-cxx11.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaTemplate/instantiate-exception-spec-cxx11.cpp?rev=217997&r1=217996&r2=217997&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaTemplate/instantiate-exception-spec-cxx11.cpp?rev=217997&r1=217996&r2=217997&view=diff</a><br>
> ==============================================================================<br>
> --- cfe/trunk/test/SemaTemplate/instantiate-exception-spec-cxx11.cpp (original)<br>
> +++ cfe/trunk/test/SemaTemplate/instantiate-exception-spec-cxx11.cpp Wed Sep 17 19:12:09 2014<br>
> @@ -58,6 +58,13 @@ namespace dr1330_example {<br>
>      S().f<S>(); // ok<br>
>      S().f<int>(); // expected-note {{instantiation of exception spec}}<br>
>    }<br>
> +<br>
> +  template<typename T><br>
> +  struct U {<br>
> +    void f() noexcept(T::error);<br>
> +    void (g)() noexcept(T::error);<br>
> +  };<br>
> +  U<int> uint; // ok<br>
>  }<br>
><br>
>  namespace core_19754_example {<br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div><br></div></div>