<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Sep 13, 2014 at 9:00 PM, Nico Weber <span dir="ltr"><<a href="mailto:thakis@chromium.org" target="_blank">thakis@chromium.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span class="">On Sat, Sep 13, 2014 at 9:00 PM, Nico Weber <span dir="ltr"><<a href="mailto:thakis@chromium.org" target="_blank">thakis@chromium.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span>On Sat, Sep 13, 2014 at 2:41 PM, JF Bastien <span dir="ltr"><<a href="mailto:jfb@google.com" target="_blank">jfb@google.com</a>></span> wrote:<br></span><span><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">Hmm, I'm not sure, I cargo-culted the le32 test and didn't think about the non-hermeticity, but this does seem like a bad issue that I should fix.<div><br></div><div>The test needs va_list, size_t and ptrdiff_t.</div></div></blockquote><div><br></div></span><div>Other tests do</div><div><br></div><div>typedef __builtin_va_list va_list;<br></div><div>typedef __SIZE_TYPE__ size_t;<br></div><div>typedef __typeof__(((int*)0)-((int*)0)) ptrdiff_t;<br></div></div></div></div></blockquote><div><br></div></span><div>…one test does `typedef __PTRDIFF_TYPE__ ptrdiff_t;` , that seems a bit nicer.</div></div></div></div></blockquote><div><br></div><div>Yes, you can rely on the define.</div><div><br></div><div>-eric</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span class=""><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div></div><div><br></div><div>for these three, respectively.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span><div dir="ltr"><div> Should I try to include clang's headers directly? They use include_next so they will pull in the default headers if I don't prevent them from doing so.</div><div><br></div><div>I'd obviously fix the le32 test (and any other in this directory). What do you recommend?</div></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Sep 12, 2014 at 5:37 PM, Nick Lewycky <span dir="ltr"><<a href="mailto:nlewycky@google.com" target="_blank">nlewycky@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div><div><div class="gmail_quote">On 12 September 2014 15:53, Nick Lewycky <span dir="ltr"><<a href="mailto:nlewycky@google.com" target="_blank">nlewycky@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><span><div class="gmail_quote">On 12 September 2014 10:52, JF Bastien <span dir="ltr"><<a href="mailto:jfb@google.com" target="_blank">jfb@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div style="overflow:hidden">--- cfe/trunk/test/Driver/<span>le64</span>-<span>unknown</span>-<span>unknown</span>.<span>cpp</span> (added)<br>
+++ cfe/trunk/test/Driver/<span>le64</span>-<span>unknown</span>-<span>unknown</span>.<span>cpp</span> Fri Sep 12 12:52:47 2014<br>
@@ -0,0 +1,137 @@<br>
+// RUN: %clang -target <span>le64</span>-<span>unknown</span>-nacl -### %s -emit-llvm-only -c 2>&1 | FileCheck %s -check-prefix=ECHO<br>
+// RUN: %clang -target <span>le64</span>-<span>unknown</span>-nacl %s -emit-llvm -S -c -o - | FileCheck %s<br>
+<br>
+// ECHO: {{.*}} "-cc1" {{.*}}<span>le64</span>-<span>unknown</span>-<span>unknown</span>.c<br>
+<br>
+// Check platform defines<br>
+#include <stdarg.h><br>
+#include <stddef.h><br></div></blockquote></div><br></span>This test is non-hermetic. Please test only the driver's behaviour in a driver test.</div></div>
</blockquote></div><div class="gmail_extra"><br></div></div></div>... or is it? We have our own stdarg.h and stddef.h in lib/Headers? Does this use those?</div></div>
</blockquote></div><br></div>
</div></div><br></span><span>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br></span></blockquote></div><br></div></div>
</blockquote></span></div><br></div></div>
<br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br></div></div>