<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; color: rgb(0, 0, 0); font-size: 14px; font-family: Calibri, sans-serif;">
<div>Hi James,</div>
<div><br>
</div>
<div>Thanks for reviewing. (Tim as well)</div>
<div><br>
</div>
<div>Updated patch attached, have retested and confirmed it all still passes.</div>
<div><br>
</div>
<div>> Do you need help committing?</div>
<div><br>
</div>
<div>Yes please.</div>
<div><br>
</div>
<div>-Graham</div>
<div><br>
</div>
<span id="OLK_SRC_BODY_SECTION">
<div style="font-family:Calibri; font-size:11pt; text-align:left; color:black; BORDER-BOTTOM: medium none; BORDER-LEFT: medium none; PADDING-BOTTOM: 0in; PADDING-LEFT: 0in; PADDING-RIGHT: 0in; BORDER-TOP: #b5c4df 1pt solid; BORDER-RIGHT: medium none; PADDING-TOP: 3pt">
<span style="font-weight:bold">From: </span>James Molloy <<a href="mailto:james@jamesmolloy.co.uk">james@jamesmolloy.co.uk</a>><br>
<span style="font-weight:bold">Date: </span>Friday, 5 September 2014 13:35<br>
<span style="font-weight:bold">To: </span>Admin <<a href="mailto:Graham.Hunter@arm.com">Graham.Hunter@arm.com</a>><br>
<span style="font-weight:bold">Cc: </span>llvm cfe <<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a>><br>
<span style="font-weight:bold">Subject: </span>Re: [PATCH] AArch32 v8 NEON intrinsics for numeric max/min and directed rounding to integral<br>
</div>
<div><br>
</div>
<div dir="ltr">Hi Graham,
<div><br>
</div>
<div>Thanks for working on this. The implementation looks fine to me, but in your testcase:</div>
<div><br>
</div>
<div>
<div>+float32x2_t test_vrndx_f32(float32x2_t a) {</div>
<div>+ // CHECK-LABEL: test_vrndx_f32</div>
<div>+ // CHECK-LABEL: call <2 x float> @llvm.arm.neon.vrintx.v2f32(<2 x float> %a)</div>
<div>+ return vrndx_f32(a);</div>
<div>+}</div>
</div>
<div><br>
</div>
<div>Only the first should be a CHECK-LABEL. The other should be a CHECK.</div>
<div><br>
</div>
<div>CHECK-LABELs are only hints to FileCheck, used to help isolate individual testcases and prevent accidental crosstalk (matching one CHECK: line in another function accidentally).</div>
<div><br>
</div>
<div>With those changed, LGTM.</div>
<div><br>
</div>
<div>Do you need help committing?</div>
<div><br>
</div>
<div>Cheers,</div>
<div><br>
</div>
<div>James</div>
</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On 5 September 2014 12:12, Graham Hunter <span dir="ltr">
<<a href="mailto:Graham.Hunter@arm.com" target="_blank">Graham.Hunter@arm.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi,<br>
<br>
This patch adds support for the 32bit numeric max/min and directed<br>
round-to-integral NEON intrinsics that were added as part of v8, along<br>
with unit tests.<br>
<span class="HOEnZb"><font color="#888888"><br>
-Graham<br>
</font></span><br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br>
</blockquote>
</div>
<br>
</div>
</span><br>
<font face="Arial" color="Black" size="2">-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents
to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.<br>
<br>
ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590<br>
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782<br>
</font>
</body>
</html>