<div dir="ltr">Looks mostly reasonable.<br><br>The changes to include/clang/Sema/SemaInternal.h seem unrelated to this patch, though - perhaps they're meant for some other patch? The TypoDiagnosticGenerator too, is an isolated/unrelated change.<br><br>It might be worth adding a test case for statement printing (StmtPrinter.cpp) with typos - if you can cause the TypoExpr to still be there when you do an AST Dump? (perhaps on invalid code? Or do you always transform the TypoExpr into /something/ else, even if you can't suggest a specific function to call?)<br><br>I'm assuming all the other changes are just necessary bits & Pieces to adding a new expr type? (eg: if I removed some of them, things would break/fail to compile/etc)<br><br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Aug 26, 2014 at 11:04 AM, Kaelyn Takata <span dir="ltr"><<a href="mailto:rikka@google.com" target="_blank">rikka@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">+dblaikie</div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Jul 31, 2014 at 1:20 PM, Kaelyn Takata <span dir="ltr"><<a href="mailto:rikka@google.com" target="_blank">rikka@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">---<br>
 include/clang/AST/DataRecursiveASTVisitor.h |  1 +<br>
 include/clang/AST/Expr.h                    | 18 ++++++++++++++++++<br>
 include/clang/AST/RecursiveASTVisitor.h     |  1 +<br>
 include/clang/Basic/StmtNodes.td            |  1 +<br>
 include/clang/Sema/SemaInternal.h           |  3 +++<br>
 include/clang/Sema/TypoCorrection.h         |  5 +++++<br>
 lib/AST/Expr.cpp                            |  1 +<br>
 lib/AST/ExprClassification.cpp              |  3 ++-<br>
 lib/AST/ExprConstant.cpp                    |  1 +<br>
 lib/AST/ItaniumMangle.cpp                   |  1 +<br>
 lib/AST/StmtPrinter.cpp                     |  5 +++++<br>
 lib/AST/StmtProfile.cpp                     |  4 ++++<br>
 lib/Sema/SemaExceptionSpec.cpp              |  1 +<br>
 lib/Sema/TreeTransform.h                    |  6 ++++++<br>
 lib/Serialization/ASTReaderStmt.cpp         |  4 ++++<br>
 lib/Serialization/ASTWriterStmt.cpp         |  6 ++++++<br>
 lib/StaticAnalyzer/Core/ExprEngine.cpp      |  1 +<br>
 tools/libclang/CXCursor.cpp                 |  1 +<br>
 18 files changed, 62 insertions(+), 1 deletion(-)<br>
<br>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>