<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">Ah...wasn't sure if we cared about C++98 on this test.</div><br class=""><div><blockquote type="cite" class=""><div class="">On Sep 2, 2014, at 16:50, David Majnemer <<a href="mailto:david.majnemer@gmail.com" class="">david.majnemer@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">dr5xx.cpp is compiled with -std=c++98 mode with -pedantic-errors. C++98/03 didn't have long long in the standard back then.</div><div class="gmail_extra"><br class=""><br class=""><div class="gmail_quote">On Tue, Sep 2, 2014 at 3:50 PM, Jordan Rose <span dir="ltr" class=""><<a href="mailto:jordan_rose@apple.com" target="_blank" class="">jordan_rose@apple.com</a>></span> wrote:<br class="">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Eh? When is "long long" not a valid C++ type?<br class="">
<div class="HOEnZb"><div class="h5"><br class="">
> On Sep 2, 2014, at 14:39, Richard Smith <<a href="mailto:richard-llvm@metafoo.co.uk" class="">richard-llvm@metafoo.co.uk</a>> wrote:<br class="">
><br class="">
> Author: rsmith<br class="">
> Date: Tue Sep 2 16:39:21 2014<br class="">
> New Revision: 216969<br class="">
><br class="">
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=216969&view=rev" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=216969&view=rev</a><br class="">
> Log:<br class="">
> Avoid test failure on platforms where size_t is long long (and thus can't be<br class="">
> directly written in strictly-conforming source code).<br class="">
><br class="">
> Modified:<br class="">
> cfe/trunk/test/CXX/drs/dr5xx.cpp<br class="">
><br class="">
> Modified: cfe/trunk/test/CXX/drs/dr5xx.cpp<br class="">
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CXX/drs/dr5xx.cpp?rev=216969&r1=216968&r2=216969&view=diff" target="_blank" class="">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CXX/drs/dr5xx.cpp?rev=216969&r1=216968&r2=216969&view=diff</a><br class="">
> ==============================================================================<br class="">
> --- cfe/trunk/test/CXX/drs/dr5xx.cpp (original)<br class="">
> +++ cfe/trunk/test/CXX/drs/dr5xx.cpp Tue Sep 2 16:39:21 2014<br class="">
> @@ -5,7 +5,8 @@<br class="">
> // FIXME: This is included to avoid a diagnostic with no source location<br class="">
> // pointing at the implicit operator new. We can't match such a diagnostic<br class="">
> // with -verify.<br class="">
> -void *operator new(__SIZE_TYPE__); // expected-warning 0-1{{missing exception spec}} expected-note{{candidate}}<br class="">
> +__extension__ typedef __SIZE_TYPE__ size_t;<br class="">
> +void *operator new(size_t); // expected-warning 0-1{{missing exception spec}} expected-note{{candidate}}<br class="">
><br class="">
> namespace dr500 { // dr500: dup 372<br class="">
> class D;<br class="">
> @@ -564,7 +565,7 @@ namespace dr552 { // dr552: yes<br class="">
> }<br class="">
><br class="">
> struct dr553_class {<br class="">
> - friend void *operator new(__SIZE_TYPE__, dr553_class);<br class="">
> + friend void *operator new(size_t, dr553_class);<br class="">
> };<br class="">
> namespace dr553 {<br class="">
> dr553_class c;<br class="">
> @@ -574,7 +575,7 @@ namespace dr553 {<br class="">
> void *p = new (c) int; // expected-error {{no matching function}}<br class="">
><br class="">
> struct namespace_scope {<br class="">
> - friend void *operator new(__SIZE_TYPE__, namespace_scope); // expected-error {{cannot be declared inside a namespace}}<br class="">
> + friend void *operator new(size_t, namespace_scope); // expected-error {{cannot be declared inside a namespace}}<br class="">
> };<br class="">
> }<br class="">
><br class="">
><br class="">
><br class="">
> _______________________________________________<br class="">
> cfe-commits mailing list<br class="">
> <a href="mailto:cfe-commits@cs.uiuc.edu" class="">cfe-commits@cs.uiuc.edu</a><br class="">
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank" class="">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br class="">
<br class="">
_______________________________________________<br class="">
cfe-commits mailing list<br class="">
<a href="mailto:cfe-commits@cs.uiuc.edu" class="">cfe-commits@cs.uiuc.edu</a><br class="">
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank" class="">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br class="">
</div></div></blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></body></html>